backport PR #2631 to take into account additionalProperties set to false #2940
Conversation
|
@Lausselloic Sorry about the conflicts, but I needed to reformat the code to match the coding styles... Can you rebase and resolve the conflicts? |
|
@Lausselloic so there is a competing change #2853 that does things a bit differently to solve a bigger issue... What are your thoughts about that one vs yours? |
|
Hello, both fixes solved my issue, so both are great. |
Lausselloic
force-pushed
the
rjsf-v5-backport-pr2631
branch
from
7c0ab4b to
cb204f3
Compare
|
@heath-freenome I've update my PR to take the other fix. I was unable to build the entire packages locally so I wasn't able to run the test proposed here : https://github.com/rjsf-team/react-jsonschema-form/pull/2853/files#diff-b7cc040be2092e8b4493e2f99a74e1b5b43189cdd143f96ce81752c357462aa0L3212 @lpillonel does this fix sounds good to you too? |
|
It looks ok for me yep |
|
@Lausselloic it looks like you'll need to run the |
…set to false in schema # Conflicts: # packages/utils/src/schema/toPathSchema.ts # packages/utils/test/schema/toPathSchemaTest.ts
Lausselloic
force-pushed
the
rjsf-v5-backport-pr2631
branch
from
c951996 to
730af54
Compare
|
@Lausselloic You'll need to resolve conflicts now. Also do run the |
|
@Lausselloic Just checking in to see whether you'll be able to update this PR before we merged the branch into master sometime next week |
Fix formatting (hopefully)
Second try fixing formatting
…set to false (rjsf-team#2940) * backport PR rjsf-team#2631 to take into account additionalProperties set to false in schema # Conflicts: # packages/utils/src/schema/toPathSchema.ts # packages/utils/test/schema/toPathSchemaTest.ts * move to fix from rjsf-team#2853 * fix linting error * run cs-format on modified files * Update packages/utils/src/schema/toPathSchema.ts Fix formatting (hopefully) * Update packages/utils/src/schema/toPathSchema.ts Second try fixing formatting Co-authored-by: LAUSSEL Loic INNOV/IT-S <[email protected]> Co-authored-by: Heath C <[email protected]>
backport #2631 in v5