Skip to content

Implemented classNames in all themes where it was missing #3032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 23, 2022
Merged

Implemented classNames in all themes where it was missing #3032

merged 1 commit into from
Aug 23, 2022

Conversation

heath-freenome
Copy link
Member

@heath-freenome heath-freenome commented Aug 22, 2022 •
edited
Loading

Reasons for making this change

  • Updated the WrapIfAdditional component to add classNames to the outer wrapper in a manner consistent with the core theme, for the following themes:
    • bootstrap-4, chakra-ui, material-ui, mui and semantic-ui
  • Updated the snapshots to add the missing classNames classes

Checklist

  • I'm updating documentation
  • I'm adding or updating code
    • I've added and/or updated tests. I've run npm run test:update to update snapshots, if needed.
    • I've updated docs if needed
    • I've updated the changelog with a description of the PR
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature

@heath-freenome
Implemented classNames in all theme where it was missing
5ff2288 
- Updated the `WrapIfAdditional` component to add `classNames` to the outer wrapper in a manner consistent with the `core` theme, for the following themes:
  - bootstrap-4, chakra-ui, material-ui, mui and semantic-ui
- Updated the snapshots to add the missing `classNames` classes
@heath-freenome heath-freenome changed the title Implemented classNames in all theme where it was missing Implemented classNames in all themes where it was missing Aug 22, 2022
@nickgros
Copy link
Contributor

Hard to make sense of these snapshot diffs, if these look good in playground then should be good to merge

@heath-freenome
Copy link
Member Author

Hard to make sense of these snapshot diffs, if these look good in playground then should be good to merge

Mostly another div was added which indented everything

@heath-freenome heath-freenome merged commit 13e451e into rjsf-team:rjsf-v5 Aug 23, 2022
@heath-freenome heath-freenome deleted the make-classNames-consistent branch August 23, 2022 15:36
heath-freenome added a commit to heath-freenome/react-jsonschema-form that referenced this pull request Aug 27, 2022
@heath-freenome
Implemented classNames in all theme where it was missing (rjsf-team#3032
8cc975c 
)

- Updated the `WrapIfAdditional` component to add `classNames` to the outer wrapper in a manner consistent with the `core` theme, for the following themes:
  - bootstrap-4, chakra-ui, material-ui, mui and semantic-ui
- Updated the snapshots to add the missing `classNames` classes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickgros nickgros nickgros approved these changes

@epicfaace epicfaace Awaiting requested review from epicfaace

@jacqueswho jacqueswho Awaiting requested review from jacqueswho

@jimmycallin jimmycallin Awaiting requested review from jimmycallin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heath-freenome @nickgros