Setup react hooks linting #3034
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heath-freenome
approved these changes
Aug 22, 2022
|
Also, I wonder why the build system isn't running? |
|
@jimmycallin Looks like you'll need to fix up a few more lint issues in other themes |
heath-freenome
pushed a commit
to heath-freenome/react-jsonschema-form
that referenced
this pull request
Aug 27, 2022
* Set up linting for react hooks * revert formatting * fix linting issues in themes * more linting issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
It's hard to remember all dependencies in useEffect et. al. without proper linting in place. This sets this up and fixes some missing dependencies. It also turns off some less critical rules that would be good to fix in the future.
Checklist
npm run test:updateto update snapshots, if needed.