Skip to content

Improve performance by wrapping event handlers in useCallback in rjsf/core #3035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 23, 2022

Conversation

jimmycallin
Copy link
Collaborator

Reasons for making this change

Improve performance by wrapping event handlers in useCallback in rjsf/core

Checklist

  • I'm updating documentation
  • I'm adding or updating code
    • I've added and/or updated tests. I've run npm run test:update to update snapshots, if needed.
    • I've updated docs if needed
    • I've updated the changelog with a description of the PR
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature

@heath-freenome
Copy link
Member

heath-freenome commented Aug 22, 2022

Can you also update the templates directory? And perhaps the widgets and templates in all the themes (in other PRs)

@jimmycallin
Copy link
Collaborator Author

Can you also update the templates directory? And perhaps the widgets and templates in all the themes (in other PRs)

i only found one applicable file in the templates directory - BaseInputTemplate. please verify i didn't miss anything. :)

i'll see if i get around to update the themes as well.

@heath-freenome
Copy link
Member

heath-freenome commented Aug 22, 2022

Can you also update the templates directory? And perhaps the widgets and templates in all the themes (in other PRs)

i only found one applicable file in the templates directory - BaseInputTemplate. please verify i didn't miss anything. :)

Looks good!

i'll see if i get around to update the themes as well.

That would be great!

@jimmycallin jimmycallin merged commit a53f887 into rjsf-v5 Aug 23, 2022
@jimmycallin jimmycallin deleted the usecallback-widgets branch August 23, 2022 07:17
jacqueswho added a commit that referenced this pull request Aug 23, 2022
commit a53f887
Author: Jimmy Callin <[email protected]>
Date:   Tue Aug 23 09:17:04 2022 +0200

    Improve performance by wrapping event handlers in useCallback in rjsf/core (#3035)
heath-freenome pushed a commit to heath-freenome/react-jsonschema-form that referenced this pull request Aug 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants