Fix hidden widget in several themes and SelectWidget in bootstrap-4 #3036
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heath-freenome
requested review from
epicfaace,
jimmycallin,
jacqueswho and
nickgros
- Updated the `FieldTemplate` in `chakra-ui`, `material-ui`, `mui` and `semantic-ui` to properly implement the hidden field - Updated `SelectWidget` in `bootstrap-4` to fix missing `htmlFor` and the `disabled` state when `readonly` - Updated snapshots to verify fixes - Also removed the `test:update` script from `core`, `utils` and `validator-ajv6` because they are useless
heath-freenome
force-pushed
the
miscellaneous-bug-fixes
branch
from
3b1acd6 to
edf8d10
Compare
nickgros
reviewed
Aug 24, 2022
jacqueswho
approved these changes
Aug 25, 2022
heath-freenome
added a commit
to heath-freenome/react-jsonschema-form
that referenced
this pull request
Aug 27, 2022
…jsf-team#3036) * Fix hidden widget in several themes and SelectWidget in bootstrap-4 - Updated the `FieldTemplate` in `chakra-ui`, `material-ui`, `mui` and `semantic-ui` to properly implement the hidden field - Updated `SelectWidget` in `bootstrap-4` to fix missing `htmlFor` and the `disabled` state when `readonly` - Updated snapshots to verify fixes - Also removed the `test:update` script from `core`, `utils` and `validator-ajv6` because they are useless * - Responded to reviewer feedback
This was referenced Aug 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
Fixes (#2571) and (#2616)
FieldTemplateinchakra-ui,material-ui,muiandsemantic-uito properly implement the hidden fieldSelectWidgetinbootstrap-4to fix missinghtmlForand thedisabledstate whenreadonlytest:updatescript fromcore,utilsandvalidator-ajv6because they are useless since those three packages do NOT have snapshotsChecklist
npm run test:updateto update snapshots, if needed.