Restored uiSchema.classNames with deprecation warning #3041
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epicfaace
reviewed
Aug 24, 2022
epicfaace
reviewed
Aug 24, 2022
heath-freenome
force-pushed
the
restore-uiSchema-classNames-deprecated
branch
from
b21d3a4 to
c8b8b77
Compare
jacqueswho
reviewed
Aug 25, 2022
There are no examples in the |
heath-freenome
force-pushed
the
restore-uiSchema-classNames-deprecated
branch
from
7b1b427 to
ea237bc
Compare
heath-freenome
commented
Aug 26, 2022
heath-freenome
commented
Aug 26, 2022
heath-freenome
commented
Aug 26, 2022
heath-freenome
commented
Aug 26, 2022
|
@nickgros @epicfaace @jacqueswho I believe this PR is ready for approval |
nickgros
approved these changes
Aug 26, 2022
jacqueswho
approved these changes
Aug 26, 2022
heath-freenome
force-pushed
the
restore-uiSchema-classNames-deprecated
branch
from
24d3c5c to
6f55f44
Compare
- Updated `SchemaField` to restore support for `uiSchema.classNames` with big fat deprecation warning - Updated the existing `classNames` test to verify restored code and deprecation warning - NOTE: Will fix up the documentation in the other PR
heath-freenome
force-pushed
the
restore-uiSchema-classNames-deprecated
branch
from
6f55f44 to
0490661
Compare
heath-freenome
force-pushed
the
restore-uiSchema-classNames-deprecated
branch
from
0490661 to
79c7ae4
Compare
heath-freenome
added a commit
to heath-freenome/react-jsonschema-form
that referenced
this pull request
Aug 27, 2022
* Restored uiSchema.classNames with deprecation warning - Updated `SchemaField` to restore support for `uiSchema.classNames` with big fat deprecation warning - Updated the existing `classNames` test to verify restored code and deprecation warning - NOTE: Will fix up the documentation in the other PR * - Responded to reviewer feedback * - Adjusted warning message * - Responded to reviewer feedback and updated migration guide
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
SchemaFieldto restore support foruiSchema.classNameswith big fat deprecation warningclassNamestest to verify restored code and deprecation warningChecklist
npm run test:updateto update snapshots, if needed.