PrimeReact support v6 #4497

jasny · 2025-02-14T15:16:25Z

Reasons for making this change

Added PrimeReact theme. PrimeReact is a popular component library for React.

PrimeReact is at version 10. A lot has changed since 2022 both v4 to v6 of rjsf and v7 to v10 of primereact. The theme was created from scratch instead of modifying the existing PR. Closes #2723

Checklist

I'm updating documentation
- I've checked the rendering of the Markdown text I've added
I'm adding or updating code
- I've added and/or updated tests. I've run npx nx run-many --target=build --exclude=@rjsf/docs && npm run test:update to update snapshots, if needed.
- I've updated docs if needed
- ~~[ ] I've updated the changelog with a description of the PR~~ (will be part of v6)
I'm adding a new feature
- I've updated the playground with an example use of the feature

MarcoFantini · 2025-03-10T10:05:45Z

Great work! This will be really useful for us!

heath-freenome · 2025-03-13T21:35:28Z

@jasny I've merged a few PRs with updates and fixes from main. You'll have to rebase and update your PR. Also, checkout the new Layout Grid in the playground and update the layoutGrid.tsx in the samples directory to add your custom uiSchema for the grid to it.

packages/primereact/package.json

packages/primereact/src/ArrayFieldTemplate/ArrayFieldTemplate.tsx

packages/primereact/src/ObjectFieldTemplate/ObjectFieldTemplate.tsx

packages/primereact/src/WrapIfAdditionalTemplate/WrapIfAdditionalTemplate.tsx

heath-freenome · 2025-04-17T22:53:31Z

@jasny are you planning to complete this theme addition? What do you need from us, if anything to get this over the line?

jasny · 2025-04-19T05:59:37Z

@heath-freenome Yes, definitely!

Unfortunately, I've been tied up with work for the past weeks, leaving no room to work on any open-source effort. This is high on my priority list, and I'll pick it up as soon as time allows me.

heath-freenome · 2025-04-23T16:56:51Z

@heath-freenome Yes, definitely!

Unfortunately, I've been tied up with work for the past weeks, leaving no room to work on any open-source effort. This is high on my priority list, and I'll pick it up as soon as time allows me.

Sounds good. We'll have the first release of v6 beta hopefully out by the end of April. Since it is a new theme, we can add it in when you are ready

jasny · 2025-04-25T20:33:20Z

@heath-freenome Can you help with the failing tests? I don't understand what needs to be fixed.

packages/primereact/package.json

packages/primereact/src/AutoCompleteWidget/AutoCompleteWidget.tsx

packages/primereact/src/BaseInputTemplate/BaseInputTemplate.tsx

packages/primereact/src/CheckboxWidget/CheckboxWidget.tsx

packages/primereact/src/CheckboxesWidget/CheckboxesWidget.tsx

packages/primereact/src/util.tsx

packages/primereact/test/Form.test.tsx

packages/primereact/test/Object.test.tsx

heath-freenome · 2025-04-25T21:28:07Z

@heath-freenome Can you help with the failing tests? I don't understand what needs to be fixed.

I noticed you copied from the semantic-ui theme. I wonder if you are picking up stuff that that theme needed that yours doesn't? I added comments about them above.

@jasny Also, you will need to run npm run cs-format to fix the linting errors. Do also consider running npm run build and npm run test before pushing again. Especially after rebasing onto the latest rjsf-v6 since I've merged a few core changes that affect snapshots

packages/primereact/package.json

jasny · 2025-04-26T20:00:50Z

@heath-freenome Please let me know if changes are needed before merging.

Btw, why isn't CI triggered?

heath-freenome · 2025-04-29T22:59:35Z

@heath-freenome Please let me know if changes are needed before merging.

Btw, why isn't CI triggered?

Because you are a first time dev, myself or somebody who is marked a reviewer for the project has to trigger it

packages/primereact/src/ArrayFieldTemplate/ArrayFieldTemplate.tsx

packages/primereact/src/CheckboxWidget/CheckboxWidget.tsx

packages/primereact/src/CheckboxesWidget/CheckboxesWidget.tsx

packages/primereact/src/WrapIfAdditionalTemplate/WrapIfAdditionalTemplate.tsx

packages/primereact/src/ObjectFieldTemplate/ObjectFieldTemplate.tsx

heath-freenome

Almost ready to merge. I'll be cutting the first v6 beta release in a few days hopefully

packages/primereact/src/ArrayFieldItemTemplate/ArrayFieldItemTemplate.tsx

packages/primereact/src/ArrayFieldTitleTemplate/ArrayFieldTitleTemplate.tsx

packages/primereact/src/AutoCompleteWidget/AutoCompleteWidget.tsx

packages/primereact/src/ColorWidget/ColorWidget.tsx

packages/primereact/src/FieldTemplate/FieldTemplate.tsx

packages/primereact/src/GridTemplate/GridTemplate.tsx

heath-freenome · 2025-04-30T15:49:03Z

packages/primereact/src/PasswordWidget/PasswordWidget.tsx

+} from '@rjsf/utils';
+import { Password } from 'primereact/password';
+
+export default function PasswordWidget<


Can you add JSDoc, feel free to copy from another theme

packages/primereact/src/UpDownWidget/UpDownWidget.tsx

packages/primereact/src/TitleField/TitleField.tsx

packages/primereact/src/WrapIfAdditionalTemplate/WrapIfAdditionalTemplate.tsx

packages/primereact/package.json

packages/playground/package.json

heath-freenome · 2025-05-01T23:32:05Z

@jasny sorry about the close. You'll have to rebase on main now and deal with the conflicts

Add `PrimeReact Customization` to docs List `@rjsf/primereact` as them in the docs

Co-authored-by: Heath C <[email protected]>

Remove unused util functions Default form test Add grid test

Mock inject stylesheet. Mock dropdown, multiselect and slider. They don't work with jsdom. Update snapshots.

Co-authored-by: Heath C <[email protected]>

Set `id` property in `ArrayFieldTitleTemplate`

heath-freenome

Just a few little changes and we are ready to merge!

heath-freenome · 2025-05-07T17:49:14Z

packages/primereact/src/DescriptionField/DescriptionField.tsx

+  const { id, description } = props;
+  if (!description) {
+    return null;
+  }
+  return <span id={id}>{description}</span>;


Please use the new RichDescription component in @rjsf/core

Suggested change

const { id, description } = props;

if (!description) {

return null;

}

return <span id={id}>{description}</span>;

const { id, description, registry, uiSchema } = props;

if (!description) {

return null;

}

return (

<span id={id}>

<RichDescription description={description} registry={registry} uiSchema={uiSchema} />

</span>

);

heath-freenome · 2025-05-07T17:49:16Z

packages/primereact/src/DescriptionField/DescriptionField.tsx

@@ -0,0 +1,17 @@
+import { DescriptionFieldProps, FormContextType, RJSFSchema, StrictRJSFSchema } from '@rjsf/utils';


Suggested change

import { DescriptionFieldProps, FormContextType, RJSFSchema, StrictRJSFSchema } from '@rjsf/utils';

import { DescriptionFieldProps, FormContextType, RJSFSchema, StrictRJSFSchema } from '@rjsf/utils';

import { RichDescription } from '@rjsf/core';

heath-freenome · 2025-05-07T17:52:08Z

packages/primereact/src/SelectWidget/SelectWidget.tsx

+export default function SelectWidget<T = any, S extends StrictRJSFSchema = RJSFSchema, F extends FormContextType = any>(
+  props: WidgetProps<T, S, F>,
+) {
+  const multiple = typeof props.multiple === 'undefined' ? false : props.multiple;


This is easier to read and shorter

Suggested change

const multiple = typeof props.multiple === 'undefined' ? false : props.multiple;

const { multiple = false } = props;

heath-freenome · 2025-05-07T17:52:28Z

packages/primereact/src/SelectWidget/SelectWidget.tsx

+  placeholder,
+  readonly,
+  value,
+  multiple,


Suggested change

multiple,

multiple = false,

heath-freenome · 2025-05-07T17:52:57Z

packages/primereact/src/SelectWidget/SelectWidget.tsx

+  multiple = typeof multiple === 'undefined' ? false : multiple;
+


Using the defaulting above alleviates the need for this

Suggested change

multiple = typeof multiple === 'undefined' ? false : multiple;

heath-freenome · 2025-05-07T19:25:28Z

@jasny After making the changes, I suggest rebuilding updating the snapshots

heath-freenome · 2025-05-08T16:41:31Z

packages/primereact/package.json

+    "@rjsf/core": "^6.x",
+    "@rjsf/utils": "^6.x",


Suggested change

"@rjsf/core": "^6.x",

"@rjsf/utils": "^6.x",

"@rjsf/core": "^6.0.0-beta",

"@rjsf/utils": "^6.0.0-beta",

heath-freenome · 2025-05-08T16:42:22Z

packages/primereact/package.json

+    "@rjsf/core": "^6.0.0-alpha.0",
+    "@rjsf/snapshot-tests": "^6.0.0-alpha.0",
+    "@rjsf/utils": "^6.0.0-alpha.0",
+    "@rjsf/validator-ajv8": "^6.0.0-alpha.0",


Suggested change

"@rjsf/core": "^6.0.0-alpha.0",

"@rjsf/snapshot-tests": "^6.0.0-alpha.0",

"@rjsf/utils": "^6.0.0-alpha.0",

"@rjsf/validator-ajv8": "^6.0.0-alpha.0",

"@rjsf/core": "^6.0.0-beta.4",

"@rjsf/snapshot-tests": "^6.0.0-beta.4",

"@rjsf/utils": "^6.0.0-beta.4",

"@rjsf/validator-ajv8": "^6.0.0-beta.4",

This was referenced Feb 14, 2025

PrimeReact support WIP #4485

Closed

Daisyui #4495

Closed

nickgros mentioned this pull request Feb 14, 2025

DaisyUI v5 + Tailwind v4 + RJSF v6 #4498

Closed

8 tasks

jasny force-pushed the primereact-v6 branch from d6a191c to 0b230c2 Compare March 8, 2025 12:59

heath-freenome reviewed Mar 14, 2025

View reviewed changes

jasny force-pushed the primereact-v6 branch 2 times, most recently from 143249a to e687f8e Compare April 24, 2025 21:45

heath-freenome requested changes Apr 25, 2025

View reviewed changes

heath-freenome reviewed Apr 25, 2025

View reviewed changes

packages/primereact/package.json Outdated Show resolved Hide resolved

heath-freenome reviewed Apr 25, 2025

View reviewed changes

packages/primereact/package.json Outdated Show resolved Hide resolved

jasny marked this pull request as ready for review April 26, 2025 19:05

heath-freenome reviewed Apr 29, 2025

View reviewed changes

jasny force-pushed the primereact-v6 branch 2 times, most recently from 90fb184 to fccb812 Compare April 30, 2025 11:21

heath-freenome reviewed Apr 30, 2025

View reviewed changes

heath-freenome reviewed May 1, 2025

View reviewed changes

packages/primereact/package.json Outdated Show resolved Hide resolved

heath-freenome reviewed May 1, 2025

View reviewed changes

packages/playground/package.json Outdated Show resolved Hide resolved

heath-freenome deleted the branch rjsf-team:main May 1, 2025 22:41

heath-freenome closed this May 1, 2025

heath-freenome reopened this May 1, 2025

heath-freenome changed the base branch from rjsf-v6 to main May 1, 2025 23:33

jasny and others added 13 commits May 7, 2025 09:22

PrimeReact support WIP

1a6a770

Primereact for v6

a843e11

Use prime in ui:option to set PrimeReact specific options.

ae4ce31

Add `PrimeReact Customization` to docs List `@rjsf/primereact` as them in the docs

Primereact snapshot from test

32fd4ff

Fix running the playground

415b525

Apply suggestions from code review

e50369b

Co-authored-by: Heath C <[email protected]>

Implemented grid template for primereact

8c2d964

Apply suggestions from code review

a09d625

Co-authored-by: Heath C <[email protected]>

npm run cs-format

45945dd

PrimeReact theme:

62eecdd

Remove unused util functions Default form test Add grid test

Fix tests for primereact.

fa60ac9

Mock inject stylesheet. Mock dropdown, multiselect and slider. They don't work with jsdom. Update snapshots.

Apply suggestions from code review

8b9c143

Co-authored-by: Heath C <[email protected]>

NPM install

64febb6

jasny force-pushed the primereact-v6 branch from fccb812 to 4f0b7ea Compare May 7, 2025 07:48

Add JSDoc for primereact.

735dee7

Set `id` property in `ArrayFieldTitleTemplate`

jasny force-pushed the primereact-v6 branch from 4f0b7ea to 735dee7 Compare May 7, 2025 07:49

Update package.json for primereact

0a1ee25

jasny requested a review from heath-freenome May 7, 2025 08:11

heath-freenome requested changes May 7, 2025

View reviewed changes

heath-freenome reviewed May 8, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PrimeReact support v6 #4497

PrimeReact support v6 #4497

jasny commented Feb 14, 2025 •

edited

Loading

MarcoFantini commented Mar 10, 2025

heath-freenome commented Mar 13, 2025

heath-freenome commented Apr 17, 2025 •

edited

Loading

jasny commented Apr 19, 2025

heath-freenome commented Apr 23, 2025

jasny commented Apr 25, 2025

heath-freenome commented Apr 25, 2025 •

edited

Loading

jasny commented Apr 26, 2025

heath-freenome commented Apr 29, 2025

heath-freenome left a comment

heath-freenome Apr 30, 2025

heath-freenome commented May 1, 2025 •

edited

Loading

heath-freenome left a comment

heath-freenome May 7, 2025

heath-freenome May 7, 2025

heath-freenome May 7, 2025

heath-freenome May 7, 2025

heath-freenome May 7, 2025

heath-freenome commented May 7, 2025

heath-freenome May 8, 2025 •

edited

Loading

heath-freenome May 8, 2025 •

edited

Loading

		@@ -0,0 +1,17 @@
		import { DescriptionFieldProps, FormContextType, RJSFSchema, StrictRJSFSchema } from '@rjsf/utils';

	import { DescriptionFieldProps, FormContextType, RJSFSchema, StrictRJSFSchema } from '@rjsf/utils';
	import { DescriptionFieldProps, FormContextType, RJSFSchema, StrictRJSFSchema } from '@rjsf/utils';
	import { RichDescription } from '@rjsf/core';

	const multiple = typeof props.multiple === 'undefined' ? false : props.multiple;
	const { multiple = false } = props;

		multiple = typeof multiple === 'undefined' ? false : multiple;

PrimeReact support v6 #4497

Are you sure you want to change the base?

PrimeReact support v6 #4497

Conversation

jasny commented Feb 14, 2025 • edited Loading

Reasons for making this change

Checklist

MarcoFantini commented Mar 10, 2025

heath-freenome commented Mar 13, 2025

heath-freenome commented Apr 17, 2025 • edited Loading

jasny commented Apr 19, 2025

heath-freenome commented Apr 23, 2025

jasny commented Apr 25, 2025

heath-freenome commented Apr 25, 2025 • edited Loading

jasny commented Apr 26, 2025

heath-freenome commented Apr 29, 2025

heath-freenome left a comment

Choose a reason for hiding this comment

heath-freenome Apr 30, 2025

Choose a reason for hiding this comment

heath-freenome commented May 1, 2025 • edited Loading

heath-freenome left a comment

Choose a reason for hiding this comment

heath-freenome May 7, 2025

Choose a reason for hiding this comment

heath-freenome May 7, 2025

Choose a reason for hiding this comment

heath-freenome May 7, 2025

Choose a reason for hiding this comment

heath-freenome May 7, 2025

Choose a reason for hiding this comment

heath-freenome May 7, 2025

Choose a reason for hiding this comment

heath-freenome commented May 7, 2025

heath-freenome May 8, 2025 • edited Loading

Choose a reason for hiding this comment

heath-freenome May 8, 2025 • edited Loading

Choose a reason for hiding this comment

jasny commented Feb 14, 2025 •

edited

Loading

heath-freenome commented Apr 17, 2025 •

edited

Loading

heath-freenome commented Apr 25, 2025 •

edited

Loading

heath-freenome commented May 1, 2025 •

edited

Loading

heath-freenome May 8, 2025 •

edited

Loading

heath-freenome May 8, 2025 •

edited

Loading