Added snapshots tests for grids #4559
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added snapshot testing for the new grid layout feature - In `snapshots`, added the new `gridTests.tsx` file that supports testing grids in the themes - Also cleaned up the other tests little bit - In `core` added `GridSnap.tsx` and changed the other snapshot tests to be `tsx` files - Also updated `LayoutGridField` to add support for the `$lookup=` prefix on string props in the children field of a gridSchema - Updated the `LayoutGridField` tests accordingly - Added the new snapshot files (and deleted the old .jsx` ones) - In `antd`, `chakra`, `fluentui-rc`, `mui`, `react-bootstrap`, `semantic-ui` and `shadcdn` added `GridSnap.tsx` - Added the new snapshot files after running the test - In playground, updated the `layoutGrid.tsx` to add a `formContext` for the `PlaceholderText` lookup
nickgros
reviewed
Apr 10, 2025
Comment on lines
+1306
to
+1307
| // @ts-expect-error TS2740 because it is missing all of the FieldProps, which we don't need | ||
| rendered: <TestRenderer data-testid={LayoutGridField.TEST_IDS.uiComponent} fullWidth />, |
There was a problem hiding this comment.
I'm surprised this equality check works, I've never thought to compare two React elements. Does this assume React.createElement is deterministic and always returns objects that can be deeply compared? Is that a safe assumption?
There was a problem hiding this comment.
Good question... I just know it works, at least with Jest deep equality :)
nickgros
reviewed
Apr 10, 2025
packages/mui/test/GridSnap.test.tsx
Outdated
Comment on lines
6
to
15
| jest.spyOn(window, 'getComputedStyle').mockImplementation(() => { | ||
| return { | ||
| width: 100, | ||
| 'box-sizing': 10, | ||
| 'padding-bottom': 1, | ||
| 'padding-top': 1, | ||
| 'border-bottom-width': 1, | ||
| 'border-top-width': 1, | ||
| } as unknown as CSSStyleDeclaration; | ||
| }); |
There was a problem hiding this comment.
is this mock implementation copied from another test suite? would it make sense to put it all in one place?
nickgros
approved these changes
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
Added snapshot testing for the new grid layout feature
snapshots, added the newgridTests.tsxfile that supports testing grids in the themescoreaddedGridSnap.tsxand changed the other snapshot tests to betsxfilesLayoutGridFieldto add support for the$lookup=prefix on string props in the children field of a gridSchemaLayoutGridFieldtests accordinglyantd,chakra,fluentui-rc,mui,react-bootstrap,semantic-uiandshadcdnaddedGridSnap.tsxlayoutGrid.tsxto add aformContextfor thePlaceholderTextlookupChecklist
npx nx run-many --target=build --exclude=@rjsf/docs && npm run test:updateto update snapshots, if needed.