Skip to content

Add copyrights back to the repository #772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aaltat opened this issue Mar 7, 2017 · 4 comments
Closed

Add copyrights back to the repository #772

aaltat opened this issue Mar 7, 2017 · 4 comments
Assignees
Labels
alpha 1 priority: medium task Generic task not listed in release notes
Milestone

Comments

@aaltat
Copy link
Contributor

aaltat commented Mar 7, 2017

The S2L is based on the work of the original SeleniumLibrary and it it seems that the copyrights where removed at some point. Add the copyrights back.

@aaltat aaltat added this to the v2.0 milestone Mar 7, 2017
@pekkaklarck
Copy link
Member

Should also include copyrights of the original S2L team and decide what copyrights we want to have for the future work. For the latter I propose Robot Framework Foundation, for the former we probably need to consult the orig team directly.

@pekkaklarck
Copy link
Member

I noticed there still was COPYRIGHT.txt in the project root and created PR #828 to update it. The most important change was updating copyright holders to this list:

Copyright 2008-2011 Nokia Networks
Copyright 2011-2016 Ryan Topac, Ed Manlove and contributors
Copyright 2016-     Robot Framework Foundation

As you can see, I explicitly mentioned only the original S2L developers @rtomac and @emanlove. Should we also include @zephraph? Any other comments from others? Let us know at least if you don't want yourself to be listed!

Once we agree what's the correct listing, we still need to add this copyright notice back to all source files.

pekkaklarck added a commit that referenced this issue Jun 20, 2017
@pekkaklarck
Copy link
Member

Just noticed that Jeremy Johnson i.e. @j1z0 is also listed as author in setup.py. Should he be listed also in copyrights in the future?

@zephraph
Copy link
Member

You can include me if you want, but it's up to you really.

aaltat added a commit that referenced this issue Aug 25, 2017
@aaltat aaltat added alpha 2 priority: medium task Generic task not listed in release notes labels Sep 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alpha 1 priority: medium task Generic task not listed in release notes
Projects
None yet
Development

No branches or pull requests

3 participants