This repository was archived by the owner on Nov 1, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3
Add DataLog #37
Merged
Add DataLog #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I seem to be getting a compile error:
|
Fixed some things, but need to go to bed:
|
Note there’s a native Python DataLogReader implementation in the allwpilib repo that could be pulled in instead (and upstream PRs welcome to clean it up). https://github.com/wpilibsuite/allwpilib/blob/main/wpiutil/examples/printlog/datalog.py |
In that case I'm fine with leaving out bindings for it, @virtuald thoughts? |
The bindings I pushed work, they just need some refinement. I should be able to get to it tonight. I'd rather go this route so there's less we have to maintain. |
Regarding py::make_iterator's useless type declaration, see pybind/pybind11#1585. |
- Removed MemoryBuffer, and only provide two ways of creating a reader instead - TODO: example needs to be better - TODO: need to provide a 'get' function for a record which figures out the right type for you - TODO: py::make_iterator isn't handled by pybind11-stubgen, which is annoying
- Add bulk of wpilib printlog example to examples
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.