-
-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs #130
docs #130
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added some comments, please reply when you have time.
In general I welcome the changes - but I would like you to clarify some nitpicks of mine (see comments).
Thank you.
@Peter-Krebs I see that your concerns are about the tags I used and navigation. So I guess you haven't seen the preview link. Please, check it: https://joaopedroas51.github.io/vue-api-query I'll mark the conversations about tags and navigation as resolved. |
@Peter-Krebs This PR add a documentation website using Nuxt Content. |
@Peter-Krebs If you're curious about how to publish the website: |
Ok that flew past me, sorry. I can see why you need the HTML tags then, I apparently never worked with a package using github.io.
Yes that's how marketing ruins the pure MarkDown syntax. It's not a criticism against you, I just like to reduce the HTML to a minimum where possible.
The link on the nuxt auth page is pretty missable as well I find. It's not a huge problem, but strictly speaking we shouldn't have important things above the first headline. |
@Peter-Krebs I added a section "links", which includes the documentation and release notes. What do you think? 😃 |
Yeah, I agree!
Looking at it again now and I agree with you. I'll update the README of auth module too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done, looking good now!
Add new docs using Nuxt Content.
See preview in: https://joaopedroas51.github.io/vue-api-query