Added ability to customize query parameter names #42
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A problem mentioned in #31, #32, and #9 is that there is no way to change the parameter names used. Some developers customize the parameter names in spatie/laravel-query-builder or (like me) use spatie/laravel-json-api-paginate to match the JSON API spec.
I've written a new test and made a small attempt at an implementation. It might not be the best way to do this but since you asked for a PR I figured this would be a good start to get the feature rolling.
The main change is that a model can extend the
parameterNames()
method to change the parameters like so: