Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fields[0].constructor === Array #43

Merged
merged 2 commits into from Feb 18, 2019
Merged

fields[0].constructor === Array #43

merged 2 commits into from Feb 18, 2019

Conversation

ghost
Copy link

@ghost ghost commented Feb 14, 2019

"fields[0].constructor === Array" is not 100% reliable.
It should be replaced by a simple Array.isArray().

I'm using vue-api-query in a nuxt environment with SSR enabled.
The behavior is quite strange: "fields[0].constructor === Array" fails only in dev mode AND server side only.

Please merge, it makes me waste a lot of time :-(

"fields[0].constructor === Array" is not 100% reliable.  
It should be replaced by a simple Array.isArray().

I'm using vue-api-query in a nuxt environment with SSR enabled.
The behavior is quite strange: "fields[0].constructor === Array" fails only in dev mode AND server side only.

Please merge, it makes me waste a lot of time :-(
@codecov
Copy link

codecov bot commented Feb 14, 2019

Codecov Report

Merging #43 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #43   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           4      4           
  Lines         237    237           
  Branches       41     41           
=====================================
  Hits          237    237
Impacted Files Coverage Δ
src/Builder.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f31d84f...feb3b48. Read the comment docs.

@robsontenorio robsontenorio merged commit 6fb56d9 into robsontenorio:master Feb 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants