feat: add new property argsString

[felipecrs]

Fixes #138

[felipecrs]

I'm testing this way:

[rogalmic]

Hmm, I like this, since it takes parsing away from extension :)

Did you test the case where argsString is not set in launch.json?

[felipecrs]

I forgot to say, it is WIP. I should at least test it more extensively.

[felipecrs]

I'm using this to test:
https://github.com/felipecassiors/vscode-bash-debug-test

[felipecrs]

Hmm, I like this, since it takes parsing away from extension :)

Did you test the case where argsString is not set in launch.json?

Tested, and now it works. However, the solution is a bit clunky.

https://github.com/felipecassiors/vscode-bash-debug-test

[felipecrs]

@rogalmic what do you think now?

[rogalmic]

I would prefer to additionally handle empty argString in extension.ts -> resolveDebugConfiguration(), just to keep handling consistent. The changes in other files are fine.

See how args are handled:

		// Fill non-"required" attributes with default values to prevent bashdb (or other programs) from panic
		if (!config.args) {
			config.args = [];
		}
		else if (!Array.isArray(config.args)) {
			return vscode.window.showErrorMessage("Please specify `args` as array of strings in launch.json.").then(_ => { return undefined; });
		}

[felipecrs]

Fixed due to your comment, way better indeed.

I also used a new approach for your argument parsing. shell-quote already provides a method for transforming args array into a string, so why not use it instead? And also, I perform no parsing anymore at argsString. The value should be already properly escaped under JSON, and in case we use the input, it will also write the values accordingly in the JSON. This enabled a much cleaner usage, take a look at how do I pass environment variables and even commands expansion.

[felipecrs]

I think this is now ready for you to review, or test. I suggest merging this PR using squash.

[rogalmic]

OK, looks very good. I will merge this to master, then test a bit. Afterwards it will be released.

It will be available for manual install* under downloads@latest link in:
https://marketplace.visualstudio.com/items?itemName=rogalmic.bash-debug

• This will have same version as current release, so manual uninstall + vscode restart is needed.

[felipecrs]

Awesome, I'm already using it! 👍