Skip to content

Don't reach into package to specify transformer #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
benmccann opened this issue Sep 13, 2021 · 3 comments · Fixed by #38
Closed

Don't reach into package to specify transformer #26

benmccann opened this issue Sep 13, 2021 · 3 comments · Fixed by #38

Comments

@benmccann
Copy link
Contributor

We shouldn't do this:

'^.+\\.svelte$': ['./node_modules/svelte-jester/dist/transformer.mjs', {preprocess: true}],

Instead it should be just svelte-jester

@rossyman
Copy link
Owner

I outlined my reasoning for doing this over here: #19 (comment) -- If this is something we can now resolve (i.e.: it automatically resolves the correct file), then I'll be happy to revert it back to svelte-jester specifically.

@bertybot
Copy link

I outlined my reasoning for doing this over here: #19 (comment) -- If this is something we can now resolve (i.e.: it automatically resolves the correct file), then I'll be happy to revert it back to svelte-jester specifically.

Totally get why you did this. Wish I would have found this earlier it would have saved me a lot of headaches. I did have to change mine a little tho since im working in a monorepo.

'^.+\\.svelte$': ['svelte-jester/dist/transformer.mjs', {preprocess: true}],

Just pathing into the module normally instead of a relative path, seems to make it more resilient. Is there a reason why we don't do this? Just curious. I could open a PR for it if you want.

@rossyman
Copy link
Owner

@bertybot Feel free to raise a PR 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants