This repository was archived by the owner on Oct 23, 2022. It is now read-only.
unixfs: feat tree building #284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koivunej
commented
Aug 5, 2020
koivunej
commented
Aug 5, 2020
koivunej
commented
Aug 5, 2020
koivunej
commented
Aug 5, 2020
koivunej
commented
Aug 5, 2020
koivunej
commented
Aug 5, 2020
koivunej
pushed a commit
to eqlabs/rust-ipfs
that referenced
this pull request
Aug 6, 2020
this uses the rust 1.45 features to remove recursion inside the macro. great for rs-ipfs#284 which adds even more complicated async-stream(s).
bors bot
added a commit
that referenced
this pull request
Aug 6, 2020
288: fix: update async-stream to 0.3 r=ljedrz a=koivunej this uses the rust 1.45 features to remove recursion inside the macro. great for #284 which adds even more complicated async-stream(s). good to go if CI passes. Co-authored-by: Joonas Koivunen <[email protected]>
|
I'll force push once #288 is merged with the few TODO comments which are missing. I am still thinking if I should render the AddErrors as StringError as a new json line since that's the best we can do. It might even trigger an error on the js-ipfs-http-client side which would be better than hanging. |
bors bot
added a commit
that referenced
this pull request
Aug 6, 2020
288: fix: update async-stream to 0.3 r=ljedrz a=koivunej this uses the rust 1.45 features to remove recursion inside the macro. great for #284 which adds even more complicated async-stream(s). good to go if CI passes. Co-authored-by: Joonas Koivunen <[email protected]>
bors bot
added a commit
that referenced
this pull request
Aug 6, 2020
288: fix: update async-stream to 0.3 r=ljedrz a=koivunej this uses the rust 1.45 features to remove recursion inside the macro. great for #284 which adds even more complicated async-stream(s). good to go if CI passes. Co-authored-by: Joonas Koivunen <[email protected]>
bors bot
added a commit
that referenced
this pull request
Aug 6, 2020
288: fix: update async-stream to 0.3 r=ljedrz a=koivunej this uses the rust 1.45 features to remove recursion inside the macro. great for #284 which adds even more complicated async-stream(s). good to go if CI passes. Co-authored-by: Joonas Koivunen <[email protected]>
koivunej
force-pushed
the
add_tree_building
branch
3 times, most recently
from
b5bf673 to
aab2e82
Compare
|
I think this is now ready for review. Thanks to npm for providing me focus time to try out the perf enchancements (which could be dropped off if they look bad enough) :) |
ljedrz
reviewed
Aug 6, 2020
ljedrz
reviewed
Aug 6, 2020
|
Wantlist cancellation failure: https://github.com/rs-ipfs/rust-ipfs/pull/284/checks?check_run_id=953826545#step:5:633 |
ljedrz
reviewed
Aug 6, 2020
ljedrz
reviewed
Aug 6, 2020
ljedrz
reviewed
Aug 6, 2020
ljedrz
reviewed
Aug 6, 2020
ljedrz
reviewed
Aug 6, 2020
ljedrz
reviewed
Aug 6, 2020
ljedrz
reviewed
Aug 6, 2020
added 4 commits
August 9, 2020 22:24
not sure what is the index file hash change.
koivunej
force-pushed
the
add_tree_building
branch
from
a6ce6f9 to
7446810
Compare
koivunej
commented
Aug 10, 2020
koivunej
commented
Aug 10, 2020
ljedrz
reviewed
Aug 10, 2020
ljedrz
reviewed
Aug 10, 2020
ljedrz
reviewed
Aug 10, 2020
ljedrz
reviewed
Aug 10, 2020
ljedrz
reviewed
Aug 10, 2020
Co-authored-by: ljedrz <[email protected]>
koivunej
force-pushed
the
add_tree_building
branch
from
bee60ae to
aaabc37
Compare
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Aug 10, 2020
284: unixfs: feat tree building r=koivunej a=koivunej Includes a `BufferingTreeBuilder` which kind of follows the js-ipfs implementation: a *complete* tree is built from path segments and later it's converted into a dag-pb by an "iterator" which walks the tree in post order, converting (rendering) the most nested elements first. Communication back to the "parent" is done using a `HashMap<u64, Vec<Option<(String, Cid, usize)>>>` which relies on initial ordering provided by `BufferingTreeBuilder` by using BTreeMap's on each level. Co-authored-by: Joonas Koivunen <[email protected]> Co-authored-by: Joonas Koivunen <[email protected]>
|
readme_doctest with a https://github.com/rs-ipfs/rust-ipfs/pull/284/checks?check_run_id=965960327#step:5:574 in wantlist_cancellation. |
|
Same with bors... Interesting. bors r- |
|
Canceled. |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes a
BufferingTreeBuilderwhich kind of follows the js-ipfs implementation: a complete tree is built from path segments and later it's converted into a dag-pb by an "iterator" which walks the tree in post order, converting (rendering) the most nested elements first. Communication back to the "parent" is done using aHashMap<u64, Vec<Option<(String, Cid, usize)>>>which relies on initial ordering provided byBufferingTreeBuilderby using BTreeMap's on each level.