Skip to content
This repository was archived by the owner on Oct 23, 2022. It is now read-only.

feat: unixfs symlink creation #302

Merged
merged 3 commits into from
Aug 14, 2020

Conversation

koivunej
Copy link
Collaborator

The minimal API and perhaps too verbose test cases around the feature. While I did check the cids to match some go-ipfs version cids, I think there might still be corner cases around even this very minimal API.

@koivunej koivunej requested a review from ljedrz August 12, 2020 08:28
@koivunej koivunej mentioned this pull request Aug 12, 2020
6 tasks
Copy link
Member

@ljedrz ljedrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor grammatical nits

@koivunej
Copy link
Collaborator Author

bors r+

@koivunej
Copy link
Collaborator Author

well actually hold up this creates more work for #294. maybe wait a while with that.

bors r-

@bors
Copy link
Contributor

bors bot commented Aug 12, 2020

Canceled.

@koivunej koivunej force-pushed the feat_unixfs_symlink_creation branch from 5d5da69 to a6728b5 Compare August 14, 2020 11:58
@koivunej
Copy link
Collaborator Author

bors r+

@koivunej
Copy link
Collaborator Author

Cancelled the pull_request workflow.

@koivunej koivunej linked an issue Aug 14, 2020 that may be closed by this pull request
6 tasks
@bors
Copy link
Contributor

bors bot commented Aug 14, 2020

Build succeeded:

@bors bors bot merged commit d977e98 into rs-ipfs:master Aug 14, 2020
@koivunej koivunej deleted the feat_unixfs_symlink_creation branch September 24, 2020 12:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ipfs-unixfs: importing
2 participants