Drop trigger based primary key support for Rails 6 #1669
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is planned to support identity type based primary key support in Oracle enhanced adapter 6. The current implementation of primary key generation is very complicated. To make it simple, Oracle enhanced adapter 6 will drop trigger based primary key support. `rake db:structure:dump` still dumps triggers if `structure_dump: db_stored_code` is configured for those who maintain triggers by themselves. Closes rsim#1643
|
How does one transition a stable production application currently under RoR 5.2.3 and Oracle enhanced adapter 5.2.8, that allows its database to manage triggers and sequence numbers by setting sequence_name to :autogenerated, to RoR 6 and Oracle enhanced adapter 6? |
|
Let me consider restoring this behavior. |
|
Have you decided on restoring this behaviour? It has been nearly 3 years and we need this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is planned to support identity type based primary key support
in Oracle enhanced adapter 6.
The current implementation of primary key generation is very complicated.
To make it simple, Oracle enhanced adapter 6 will drop
trigger based primary key support.
rake db:structure:dumpstill dumps triggersif
structure_dump: db_stored_codeis configuredfor those who maintain triggers by themselves.
Closes #1643