Setup 5-1-maintenance without Rails 7 but with Ruby 3.1 #2562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirj
force-pushed
the
ruby-31-5-1-maintenance
branch
2 times, most recently
from
34c6391 to
3cc2457
Compare
Add additional logic to the ActionMailer argument parsing to accomodate for differences under Ruby 3.1/Rails 6.1 Co-authored-by: Fabio Napoleoni <[email protected]> Co-authored-by: Phil Pirozhkov <[email protected]>
pirj
force-pushed
the
ruby-31-5-1-maintenance
branch
from
3cc2457 to
a687a8e
Compare
|
Note to self - don't call branches ending with |
|
@JonRowe Green. Does it look good to you? |
|
I'll go ahead and merge this. |
|
@pirj I'm going to be unpicking this a bit, it includes changes not needed, I was working on this on my machine but just hadn't responded. |
|
Please let me know what you plan to remove from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rails 7 will be supported in rspec-rails 6 via
main, this just tracks Ruby 3.1 support into the upcoming 5.1.x release.