Skip to content

fix: dont include new message in chat history #432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 18, 2024

Conversation

thucpn
Copy link
Collaborator

@thucpn thucpn commented Nov 18, 2024

Summary by CodeRabbit

  • New Features

    • Enhanced chat functionality by refining the context of chat history, now excluding the last user message for improved processing.
  • Bug Fixes

    • Adjusted how chat history is populated to ensure more relevant context is passed to the chat engine.
    • Implemented a fix to prevent the inclusion of user messages in the chat history, enhancing privacy.

Copy link

changeset-bot bot commented Nov 18, 2024

🦋 Changeset detected

Latest commit: c9c9f18

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-llama Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

coderabbitai bot commented Nov 18, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The changes in this pull request involve modifications to the chat function in two files: chat.controller.ts and route.ts. The primary alteration is in how the chatHistory variable is assigned; it now slices the messages array to exclude the last message, rather than including the entire array. This change affects the context of the chat history used in the chat engine's processing, while other aspects of the functions, such as error handling and response streaming, remain unchanged.

Changes

File Path Change Summary
templates/types/streaming/express/src/controllers/chat.controller.ts Modified chatHistory to exclude the last message from the messages array.
templates/types/streaming/nextjs/app/api/chat/route.ts Modified chatHistory to exclude the last message from the messages array.
.changeset/brave-pears-reflect.md Introduced a patch to prevent user messages from being included in chat history.

Possibly related PRs

  • feat: use llamacloud for chat #149: The changes in this PR also modify the chatHistory variable in a similar manner, slicing the messages array to exclude the last message, which directly relates to the handling of chat history in the main PR.
  • refactor: make components resuable for chat llm #202: This PR focuses on enhancing the reusability of components for chat LLMs, which may relate to the overall chat functionality being modified in the main PR, particularly in how chat history is managed.
  • fix: always send chat data when submit message #213: This PR addresses sending chat data when submitting messages, which could be relevant to the context of managing chat history and user messages in the main PR.
  • fix: dont use props as state in chat suggestion component #267: This PR fixes the handling of props in the chat suggestion component, which may relate to the overall chat message handling and context management discussed in the main PR.
  • feat: use LlamaIndexAdapter #302: The integration of LlamaIndexAdapter in this PR modifies how chat responses are handled, which could be relevant to the changes in the chat history management in the main PR.
  • feat: use latest chat UI #418: This PR updates the chat UI, which may involve changes in how chat messages and history are displayed, potentially connecting to the changes made in the main PR regarding chat history management.

Poem

In the chat where messages flow,
A slice of history, now we know.
The last one's gone, a fresh new start,
For clearer context, it plays its part.
With every chat, we hop and cheer,
For changes made, let’s spread the cheer! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@marcusschiesser marcusschiesser merged commit 00f0b3a into main Nov 18, 2024
9 of 14 checks passed
@marcusschiesser marcusschiesser deleted the fix/dont-include-new-message-in-chat-history branch November 18, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants