Skip to content

Update bitvec to 1.0.1 #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 1, 2022
Merged

Update bitvec to 1.0.1 #25

merged 2 commits into from
Dec 1, 2022

Conversation

cecton
Copy link
Member

@cecton cecton commented Nov 16, 2022

Fixes #24

@cecton
Copy link
Member Author

cecton commented Nov 16, 2022

hey @bgilbert 👋 I'm always in doubt when updating dependencies. I think it would be fine to make a patch release for this fix because I don't change anything in the API of mbrman, only a dependency of ours is making breaking changes in their API?

BUT here, since I need to update the MSRV, I'm making a breaking change so I need to bump the major?

ImperfektDaemon added a commit to ImperfektDaemon/bootloader that referenced this pull request Nov 21, 2022
@ImperfektDaemon
Update Cargo.toml
c402db2 
rust-disk-partition-management/mbrman#25
@r3dlight
Copy link

Hi,

I understand the need for backward compatibility, but IMHO 1.56 is already relatively old :)
What do you think?

@phil-opp phil-opp mentioned this pull request Nov 23, 2022
Merged
2 tasks
@cecton
Copy link
Member Author

cecton commented Dec 1, 2022

I will just merge it for now as a patch release. In any case, nobody can build mbrman in its current state! Worst case scenario I will yank the version later

@cecton cecton merged commit 8f10408 into rust-disk-partition-management:main Dec 1, 2022
@cecton cecton deleted the update-to-bitvec-1.0.1 branch December 1, 2022 06:23
@cecton
Copy link
Member Author

cecton commented Dec 1, 2022

Released 0.5.1

@cecton
Copy link
Member Author

cecton commented Jan 15, 2023

I actually got the answer I was looking for on some other ticket rust-disk-partition-management/gptman#113 (comment)

Since mbrman is in 0. version, I think the bump is fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Outdated bitvec dependency
2 participants
@cecton @r3dlight