Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is31fl3728 #478

Merged
merged 4 commits into from
Feb 19, 2025
Merged

Is31fl3728 #478

merged 4 commits into from
Feb 19, 2025

Conversation

leonidv
Copy link
Contributor

@leonidv leonidv commented Feb 9, 2025

There is no introduction article, but has some example's projects. One of them is included in the README.

Driver supports rtt-debug and embedded-graphics.

IS31FL3728 is a general purpose 8×8 LED matrix driver which features an audio frequency equalizer (EQ) mode or a general LED dot matrix display mode. The matrix picture brightness can be modulated by audio. In either the audio EQ mode or matrix display mode, the array is internally scanned, and requires only one-time programming, thus eliminating the need for real time system resource utilization.

@berkus
Copy link
Member

berkus commented Feb 11, 2025

Hi! Thanks for the PR, could you please add the following piece to your README?

IS31FL3728 is a general purpose 8×8 LED matrix driver which features an audio frequency equalizer (EQ) mode or a general LED dot matrix display mode. The matrix picture brightness can be modulated by audio. In either the audio EQ mode or matrix display mode, the array is internally scanned, and requires only one-time programming, thus eliminating the need for real time system resource utilization.

The README jumps straight into the "how" but explaining the "what" in the beginning would be very nice.

@leonidv
Copy link
Contributor Author

leonidv commented Feb 16, 2025

Done!

@berkus berkus merged commit 99a2471 into rust-embedded:master Feb 19, 2025
1 check passed
@berkus
Copy link
Member

berkus commented Feb 19, 2025

Done!

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants