Comprehensively re-worked. #4
Conversation
jonathanpallant
force-pushed
the
implement
branch
from
390f02b to
918a78a
Compare
This is based off my copy at https://github.com/ferrous-systems/cortex-r/, which you can visit for the pre-history. My only changes in moving to this repository were removing the Ferrocene build (because you don't have a key for it), and adding some QEMU based tests.
jonathanpallant
force-pushed
the
implement
branch
from
918a78a to
c3a6e22
Compare
tee runs before rustc, so it might not be there
|
This is stuck pending rust-embedded/wg#818 because the cortex-r team is currently empty. |
| @@ -1,25 +1,19 @@ | |||
| Copyright (c) 2019 The Cortex-R team | |||
| Copyright (c) 2025 Ferrous Systems | |||
There was a problem hiding this comment.
I don't think you can just change the copyright holder like that, I think you need permission from someone on behalf of the cortex-r team? I think you could add Ferrous as an additional copyright holder though?
I'm not sure if the WG has a policy on these copyright lines though, I'm not sure if as a contributor you're expected to assign the copyright back to the project? cc @adamgreig Sorry, not sure who else to ask 🙈.
There was a problem hiding this comment.
We don't have a policy; copyrights are owned by the contributors and must be licensed under the project's license. In this case I don't think anything remains from the original work, so there wouldn't be an issue removing the original copyright line. In practice this is a new project in the same repository, which is why I suggested pushing a new root commit instead of a PR, but this serves the same effect in the end.
There was a problem hiding this comment.
I'm of the opinion that nothing remains of the original repo but the team will likely add PRs quite soon so I'm happy to include both lines in the licence file if it helps.
There was a problem hiding this comment.
Sounds reasonable to me. I'm not really following the process that closely, but I just noticed that and thought I'd mention it. If it's essentially a new project I don't think this matters.
|
OK I'm bypassing merge with a force push |
This is based off my copy at https://github.com/ferrous-systems/cortex-r/, which you can visit for the pre-history. My only changes in moving to this repository were removing the Ferrocene build (because you don't have a key for it), and adding some QEMU based tests.
See the README for details.