Skip to content

Feature request: Confusing task names #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bradleyharden opened this issue Nov 5, 2020 · 6 comments
Closed

Feature request: Confusing task names #99

bradleyharden opened this issue Nov 5, 2020 · 6 comments

Comments

@bradleyharden
Copy link

Hi,

I didn't have much experience with VSCode before using it with Rust. I was working with Cortex-Debug and the preLaunchTask field. The current Rust task names look like shell commands. Because of that, I assumed I could change the preLaunchTask string to a different shell command and it would work. I only realized later that the preLaunchTask string is actually a task name, and that the task names just happen to look like shell commands.

I think this is misleading and probably a source of confusion for others who are not familiar with VSCode tasks. Can I suggest changing the names to something that doesn't look like a shell command?

@rubberduck203
Copy link
Contributor

I’m open to suggestions if you have better names in mind.

I assume you’re talking about these labels?

"label": "cargo build",

@bradleyharden
Copy link
Author

@rubberduck203, yes that's what I'm talking about. I didn't have anything specific in mind. I just want something that looks like a label rather than a shell command. Maybe Cargo - Build and Cargo - Build (release), or something like that? It's also not that big of a deal. I figured it out. It was just a bit confusing.

@rubberduck203
Copy link
Contributor

rubberduck203 commented Nov 7, 2020

How about the following?

  • Cargo Build (debug)
  • Cargo Build (release)
  • Cargo Build Examples (debug)
  • Cargo Build Examples (release)
  • Cargo Clean

Also, feel free to submit a PR, otherwise I'll get around to it sometime soon-ish.

@bradleyharden
Copy link
Author

Those look good to me.

There's no rush. I'll also try to get around to it soon, but you might beat me. Thanks for considering the change.

@rubberduck203
Copy link
Contributor

rubberduck203 commented Nov 9, 2020

@bradleyharden PR #100 is open. Just need to wait for a maintainer now.
Thanks for bringing it to my attention.

adamgreig added a commit that referenced this issue Nov 9, 2020
Fixes #99: Disambiguates VSCode Tasks
@bradleyharden
Copy link
Author

Thanks @rubberduck203!

therealfrauholle pushed a commit to therealfrauholle/cortex-m-quickstart that referenced this issue Jun 20, 2023
Using the equivalent command line as the task name caused some confusion.
Users were under the impression that they could use any valid cargo command as a preLaunchTask in the launch configurations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants