Skip to content

move all check_name's under strict feature #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

burrbull
Copy link
Member

No description provided.

@burrbull burrbull requested a review from a team as a code owner March 28, 2021 06:29
@adamgreig
Copy link
Member

bors try

bors bot added a commit that referenced this pull request Mar 28, 2021
@adamgreig
Copy link
Member

Looks like clippy is failing with:

error: error reading Clippy's configuration file /home/runner/.cargo/registry/src/gb.xjqchip.workers.dev-1ecc6299db9ec823/anyhow-1.0.40/.clippy.toml: unknown field msrv, expected one of blacklisted-names, cognitive-complexity-threshold, cyclomatic-complexity-threshold, doc-valid-idents, too-many-arguments-threshold, type-complexity-threshold, single-char-binding-names-threshold, too-large-for-stack, enum-variant-name-threshold, enum-variant-size-threshold, verbose-bit-mask-threshold, literal-representation-threshold, trivial-copy-size-limit, too-many-lines-threshold, third-party

I think we need to include the bump in Rust version clippy uses from #140 (https://github.com/rust-embedded/svd/pull/140/files#diff-8fbf9e9b0b12515f84b26e686fd2e8fa9877b4a11348bcfddff2f4e33007f977R15) to this PR before we can merge this one. @therealprof I guess this is also a reason to bump the MSRV!

@adamgreig
Copy link
Member

This PR can merge as part of #140.

@therealprof
Copy link
Contributor

@adamgreig Well, well... 😉

@burrbull burrbull closed this Mar 28, 2021
@bors
Copy link
Contributor

bors bot commented Apr 3, 2021

try

Timed out.

@burrbull burrbull deleted the strict branch April 26, 2021 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants