cortex-m: generate code that compiles on stable #203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
japaric
changed the title
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
May 12, 2018
203: cortex-m: generate code that compiles on stable r=japaric a=japaric This is still missing some stuff: - svd2rust must now generate an interrupts.x linker script and a build script that puts the linker script somewhere the linker can find it. See japaric/stm32f103xx#24 for a sample of what those files look like. - we have to decide how to organize the svd2rust output. It probably makes sense to generate 3 files on $PWD (lib.rs, build.rs, interrupts.x) for Cortex-M and a single lib.rs for the other targets. - I probably broke the other targets; need to test them Co-authored-by: Jorge Aparicio <[email protected]>
|
@jamesmunns heads up. This PR breaks svd2rust-regress because svd2rust now emits three files in the current directory instead of dumping the generated code to stdout. |
Build failed |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
May 12, 2018
203: cortex-m: generate code that compiles on stable r=japaric a=japaric This is still missing some stuff: - svd2rust must now generate an interrupts.x linker script and a build script that puts the linker script somewhere the linker can find it. See japaric/stm32f103xx#24 for a sample of what those files look like. - we have to decide how to organize the svd2rust output. It probably makes sense to generate 3 files on $PWD (lib.rs, build.rs, interrupts.x) for Cortex-M and a single lib.rs for the other targets. - I probably broke the other targets; need to test them Co-authored-by: Jorge Aparicio <[email protected]>
|
All the vendor tests passed locally so merging manually. |
Build failed |
bors bot
added a commit
to rust-embedded/cortex-m-quickstart
that referenced
this pull request
May 12, 2018
29: use less unstable dependencies r=japaric a=japaric This PR and the ones at the bottom reduce the number of unstable features needed for Cortex-M development to a single one: `lang = "panic_fmt"`, which already has a path towards stabilization and which we hope to get on stable by 1.28. [Check out the temporary documentation](https://japaric.github.io/cortex-m-quickstart/cortex_m_quickstart/index.html) (we still need more docs) to try out this preview. We would love your input on [these unresolved questions](rust-embedded/cortex-m-rt#69 (comment)) This PR depends on: - rust-embedded/cortex-m-rt#69 - rust-embedded/cortex-m#88 - rust-embedded/panic-semihosting#2 - rust-embedded/svd2rust#203 - japaric/stm32f103xx#24 Co-authored-by: Jorge Aparicio <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still missing some stuff:
svd2rust must now generate an interrupts.x linker script and a build script that puts the linker script somewhere the linker can find it. See regenerate using svd2rust v0.13.0 japaric/stm32f103xx#24 for a sample of what those files look like.
we have to decide how to organize the svd2rust output. It probably makes sense to generate 3 files on $PWD (lib.rs, build.rs, interrupts.x) for Cortex-M and a single lib.rs for the other targets.
I probably broke the other targets; need to test them