-
Notifications
You must be signed in to change notification settings - Fork 36
mmaps derivedFrom markers #123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for this PR! I think it might be clearer if registers were handled the same as peripherals - print out all the fields of the register it's derived from, instead of just marking what it's derived from (it may be hard for someone to even look up the name/path of the derivation). But, I don't know how easy it is to find the parent register, I couldn't work it out very quickly. |
It is definitely not easy. I think this task is not worth the time you can spent on it PS. See |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, fair enough. Let's go with this for now anyway.
bors r+
123: mmaps derivedFrom markers r=adamgreig a=burrbull Co-authored-by: Andrey Zgarbul <[email protected]>
Build failed: |
bors retry |
🔒 Permission denied Existing reviewers: click here to make burrbull a reviewer |
bors r=@adamgreig |
🔒 Permission denied Existing reviewers: click here to make burrbull a reviewer |
bors retry |
Build succeeded: |
No description provided.