Skip to content

mmaps derivedFrom markers #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 24, 2022
Merged

mmaps derivedFrom markers #123

merged 2 commits into from
Aug 24, 2022

Conversation

burrbull
Copy link
Member

No description provided.

@adamgreig
Copy link
Member

Thanks for this PR! I think it might be clearer if registers were handled the same as peripherals - print out all the fields of the register it's derived from, instead of just marking what it's derived from (it may be hard for someone to even look up the name/path of the derivation). But, I don't know how easy it is to find the parent register, I couldn't work it out very quickly.

@burrbull
Copy link
Member Author

burrbull commented Aug 22, 2022

It is definitely not easy. I think this task is not worth the time you can spent on it

PS. See svd_parser::expand::Index

Copy link
Member

@adamgreig adamgreig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, fair enough. Let's go with this for now anyway.

bors r+

bors bot added a commit that referenced this pull request Aug 24, 2022
123: mmaps derivedFrom markers r=adamgreig a=burrbull



Co-authored-by: Andrey Zgarbul <[email protected]>
@bors
Copy link
Contributor

bors bot commented Aug 24, 2022

Build failed:

@burrbull
Copy link
Member Author

bors retry

@bors
Copy link
Contributor

bors bot commented Aug 24, 2022

🔒 Permission denied

Existing reviewers: click here to make burrbull a reviewer

@burrbull
Copy link
Member Author

bors r=@adamgreig

@bors
Copy link
Contributor

bors bot commented Aug 24, 2022

🔒 Permission denied

Existing reviewers: click here to make burrbull a reviewer

@adamgreig
Copy link
Member

bors retry

@bors
Copy link
Contributor

bors bot commented Aug 24, 2022

@bors bors bot merged commit 5921b40 into master Aug 24, 2022
@bors bors bot deleted the single branch August 24, 2022 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants