-
Notifications
You must be signed in to change notification settings - Fork 36
ignore if not exists #176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ignore if not exists #176
Conversation
I like the idea, but I'm not totally sure about the syntax. Maybe it's OK, but I worry it will look too confusing, or might be mixed up for a real start of a rule. Could you add it to the README too as an example? Maybe another option is a "_missing_ok: True" field. It can't be used everywhere, but I think it could be used anywhere that we want to patch something and it might not exist. |
Adding option is not ok because there is not always an a hash, sometimes there is also an array or nothing. |
Yet one argument against |
1f09b9e
to
4988a17
Compare
c9aa6c6
to
cc3b963
Compare
cc @Emilgardis @kossnikita do you have any thoughts/suggestions? |
I don't like |
What should it be? Suffix or prefix? And what sequence of symbols is better (not allowed in svd names and glob syntax, easy for search)? |
Tilde maybe? |
Is it possible to do this regex-like [abc] or [a,b,c]? "[TIM[18],TIM20]": or "(TIM[18],TIM20)?": EDIT: It is more correct to use |
It is possible to check both prefix and suffix, but I don't like it:
|
Sorry, I'm new and don't know that much about crates. This clarifies a lot for me. Then the prefix seems to be the best solution. |
Merging. |
Closes #67