Skip to content

N34: Release #1060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jun 8, 2022
Merged

N34: Release #1060

merged 12 commits into from
Jun 8, 2022

Conversation

ozkriff
Copy link
Member

@ozkriff ozkriff commented Jun 8, 2022 •
edited
Loading

Preview (e1191f1): https://rust-gamedev-preview.netlify.app/news/034

Everyone is invited to review!

Hope to merge this in a few hours if there're no objections.

Part of #1033

@ozkriff ozkriff mentioned this pull request Jun 8, 2022
Closed
60 tasks
@AngelOnFira
Copy link
Member

@ozkriff I have some changes in ozkriff#4

@AngelOnFira
Copy link
Member

Can we reduce the size of these images?

content/news/034/cnc-preview.png
content/news/034/dims-video-preview.jpg
content/news/034/gfs-youtube-preview.jpg

AngelOnFira
AngelOnFira approved these changes Jun 8, 2022
View reviewed changes
Copy link
Member

@AngelOnFira AngelOnFira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After my recommendations are fixed, it looks good to me 🎉

17cupsofcoffee
17cupsofcoffee approved these changes Jun 8, 2022
View reviewed changes
Copy link
Collaborator

@17cupsofcoffee 17cupsofcoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ozkriff ozkriff merged commit c9ac035 into rust-gamedev:source Jun 8, 2022
@ozkriff ozkriff deleted the n34-release branch June 8, 2022 19:04
@ozkriff ozkriff mentioned this pull request Aug 11, 2022
Closed
72 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@17cupsofcoffee 17cupsofcoffee 17cupsofcoffee approved these changes

@AngelOnFira AngelOnFira AngelOnFira approved these changes

@ManevilleF ManevilleF ManevilleF approved these changes

@kvark kvark Awaiting requested review from kvark

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ozkriff @AngelOnFira @17cupsofcoffee @ManevilleF