Skip to content

N37: Notan v0.6 #1139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 8, 2022
Merged

N37: Notan v0.6 #1139

merged 7 commits into from
Sep 8, 2022

Conversation

Nazariglez
Copy link
Contributor

Part of #1134

Thanks!

@Nazariglez Nazariglez changed the title Notan v0.6 N37: Notan v0.6 Sep 4, 2022
ozkriff
ozkriff requested changes Sep 4, 2022
View reviewed changes
Copy link
Member

@ozkriff ozkriff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please make the gif smaller? <2.5mb

@Nazariglez
Copy link
Contributor Author

Of course! Done

@Nazariglez Nazariglez requested a review from ozkriff September 5, 2022 20:50
17cupsofcoffee
17cupsofcoffee requested changes Sep 6, 2022
View reviewed changes
Copy link
Collaborator

@17cupsofcoffee 17cupsofcoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the GIF was put in the 035 folder instead of overwriting the old version?

@Nazariglez
Copy link
Contributor Author

Oops! Sorry about this, I did it in a rush and I did not check it twice. Fixed.

@Nazariglez Nazariglez requested review from 17cupsofcoffee and ozkriff and removed request for ozkriff and 17cupsofcoffee September 7, 2022 10:21
ozkriff
ozkriff approved these changes Sep 7, 2022
View reviewed changes
Copy link
Member

@ozkriff ozkriff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@17cupsofcoffee 17cupsofcoffee merged commit df58786 into rust-gamedev:source Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ozkriff ozkriff ozkriff approved these changes

@17cupsofcoffee 17cupsofcoffee 17cupsofcoffee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Nazariglez @ozkriff @17cupsofcoffee