Skip to content

N37: Cybergate #1140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Sep 8, 2022
Merged

N37: Cybergate #1140

merged 18 commits into from
Sep 8, 2022

Conversation

cybersoulK
Copy link
Contributor

Part of #1134

@cybersoulK
Copy link
Contributor Author

cybersoulK commented Sep 5, 2022 •
edited
Loading

i am not sure if the last 3 bullet points are necessary.
Feel free to remove and change on the final review

17cupsofcoffee
17cupsofcoffee approved these changes Sep 6, 2022
View reviewed changes
Copy link
Collaborator

@17cupsofcoffee 17cupsofcoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just one bit i'm not sure about

ozkriff
ozkriff requested changes Sep 7, 2022
View reviewed changes
Copy link
Member

@ozkriff ozkriff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm expect for the image size

Only include one image (<300kb) or GIF (<2.5mb).

Could you optimize it a little, please?

ozkriff
ozkriff approved these changes Sep 8, 2022
View reviewed changes
Copy link
Member

@ozkriff ozkriff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@17cupsofcoffee 17cupsofcoffee merged commit 5dc3429 into rust-gamedev:source Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ozkriff ozkriff ozkriff approved these changes

@17cupsofcoffee 17cupsofcoffee 17cupsofcoffee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cybersoulK @ozkriff @17cupsofcoffee