Skip to content

N38: godot-rust #1160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 5, 2022
Merged

N38: godot-rust #1160

merged 2 commits into from
Oct 5, 2022

Conversation

Bromeon
Copy link
Contributor

@Bromeon Bromeon commented Oct 4, 2022

Part of #1157

@Bromeon
Copy link
Contributor Author

Bromeon commented Oct 4, 2022

The rules say images should precede text. This would take the mentioned #[method] feature quite out of context; but if it's desired, I can gladly change it.

ozkriff
ozkriff approved these changes Oct 4, 2022
View reviewed changes
Copy link
Member

@ozkriff ozkriff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@17cupsofcoffee 17cupsofcoffee merged commit 836d96e into rust-gamedev:source Oct 5, 2022
@Bromeon Bromeon deleted the n38 branch October 5, 2022 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ozkriff ozkriff ozkriff approved these changes

@17cupsofcoffee 17cupsofcoffee 17cupsofcoffee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Bromeon @ozkriff @17cupsofcoffee