Skip to content

N15: Add Antorum Online #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 3, 2020
Merged

N15: Add Antorum Online #321

merged 6 commits into from
Nov 3, 2020

Conversation

Dooskington
Copy link
Contributor

Part of #320 ("Newsletter 15")

17cupsofcoffee
17cupsofcoffee requested changes Nov 1, 2020
View reviewed changes
Copy link
Collaborator

@17cupsofcoffee 17cupsofcoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Content looks good, and thank you for fixing the CI failures!

Just a couple of comments:

@Dooskington
Copy link
Contributor Author

Thanks for the review @17cupsofcoffee, just made an update to resolve those two issues you mentioned.

17cupsofcoffee
17cupsofcoffee approved these changes Nov 1, 2020
View reviewed changes
Copy link
Collaborator

@17cupsofcoffee 17cupsofcoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the quick fixes!

@ozkriff ozkriff mentioned this pull request Nov 2, 2020
Closed
54 tasks
ozkriff
ozkriff approved these changes Nov 3, 2020
View reviewed changes
Copy link
Member

@ozkriff ozkriff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 (Changed the alt text & made a few small fmt tweaks)

@ozkriff ozkriff merged commit c0d6344 into rust-gamedev:source Nov 3, 2020
@ozkriff
Copy link
Member

ozkriff commented Nov 3, 2020

Merged, thanks for the PR! It's good to see your project's updates again :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ozkriff ozkriff ozkriff approved these changes

@17cupsofcoffee 17cupsofcoffee 17cupsofcoffee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dooskington @ozkriff @17cupsofcoffee