Skip to content

N15: Add Camp Misty #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 3, 2020
Merged

N15: Add Camp Misty #323

merged 4 commits into from
Nov 3, 2020

Conversation

ReeCocho
Copy link
Contributor

@ReeCocho ReeCocho commented Nov 1, 2020

Part of #320 ("Newsletter 15")

17cupsofcoffee
17cupsofcoffee requested changes Nov 2, 2020
View reviewed changes
Copy link
Collaborator

@17cupsofcoffee 17cupsofcoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content looks okay, just a minor issue with the title.

@ozkriff ozkriff mentioned this pull request Nov 2, 2020
Closed
54 tasks
ozkriff
ozkriff approved these changes Nov 3, 2020
View reviewed changes
Copy link
Member

@ozkriff ozkriff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 (Fixed a title link and made a few fmt tweaks for consistency)

@17cupsofcoffee
Copy link
Collaborator

17cupsofcoffee commented Nov 3, 2020 •
edited
Loading

The title link still isn't rendering properly.

@ReeCocho
Copy link
Contributor Author

ReeCocho commented Nov 3, 2020

So sorry! Should be fixed with the latest commit.

@17cupsofcoffee
Copy link
Collaborator

So sorry! Should be fixed with the latest commit.

No problem, thank you for the fix!

@ozkriff
Copy link
Member

ozkriff commented Nov 3, 2020

Fixed a title link and made a few fmt tweaks for consistency
The title link still isn't rendering properly.

Dammit, I forgot to actually push the commit))

@ozkriff ozkriff merged commit cb7ec7c into rust-gamedev:source Nov 3, 2020
@ozkriff
Copy link
Member

ozkriff commented Nov 3, 2020

Merged, thanks for the PR!

@ReeCocho
Copy link
Contributor Author

ReeCocho commented Nov 3, 2020

Thank you for including my game in the newsletter!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ozkriff ozkriff ozkriff approved these changes

@17cupsofcoffee 17cupsofcoffee 17cupsofcoffee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ReeCocho @17cupsofcoffee @ozkriff