Skip to content

N15: Sun Prison #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 6, 2020
Merged

N15: Sun Prison #344

merged 8 commits into from
Nov 6, 2020

Conversation

ropewalker
Copy link
Contributor

Part of #320 ("Newsletter 15").

Part of rust-gamedev#320 ("Newsletter 15").
Remove trailing spaces and shorten lines to 80 symbols.
Split line 358 to two lines not longer than 80 symbols each.
Copy link
Collaborator

@17cupsofcoffee 17cupsofcoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for the most part! Your 2 link isn't rendering properly, though - you can't break the link text and the link ref across 2 lines like that, I don't think.

@ropewalker
Copy link
Contributor Author

@17cupsofcoffee You are right, let me fix it!

Fix broken link on line 358
@ropewalker
Copy link
Contributor Author

@17cupsofcoffee Fixed now.

Copy link
Collaborator

@17cupsofcoffee 17cupsofcoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Member

@ozkriff ozkriff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 (made a few style tweaks)

@ozkriff ozkriff merged commit 189239d into rust-gamedev:source Nov 6, 2020
@ozkriff
Copy link
Member

ozkriff commented Nov 6, 2020

Thanks for the PR!

@ropewalker ropewalker deleted the n15_sun_prison branch November 6, 2020 06:40
@ozkriff ozkriff mentioned this pull request Nov 6, 2020
54 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants