Skip to content

N17: Add Harvest Hero #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 11, 2021
Merged

N17: Add Harvest Hero #418

merged 4 commits into from
Jan 11, 2021

Conversation

Bombfuse
Copy link
Contributor

@Bombfuse Bombfuse commented Jan 5, 2021 •
edited by ozkriff
Loading

Part of #408 ("Newsletter 17")

@ozkriff ozkriff changed the title Add Harvest Hero section to Games N17: Add Harvest Hero Jan 5, 2021
@ozkriff ozkriff mentioned this pull request Jan 5, 2021
Closed
ozkriff
ozkriff approved these changes Jan 11, 2021
View reviewed changes
Copy link
Member

@ozkriff ozkriff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 (made a few small style and fmt tweaks for consistency with the rest of the newsletter)

@ozkriff
Copy link
Member

ozkriff commented Jan 11, 2021

Thanks, merged!

Also,

Don't send PRs from your main branch, create a unique branch (named like n14_zemeroth, n12_veloren, etc) for each PR. This allows sending multiple simultaneous PRs and simplifies the creation of the next PRs.

please, don't forget to reset your fork's source branch before making a PR next time!

@ozkriff ozkriff merged commit f68000a into rust-gamedev:source Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ozkriff ozkriff ozkriff approved these changes

@17cupsofcoffee 17cupsofcoffee 17cupsofcoffee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Bombfuse @ozkriff @17cupsofcoffee