N18: SeniorSKY #455 #466
Merged
N18: SeniorSKY #455 #466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ozkriff
requested changes
Feb 3, 2021
There was a problem hiding this comment.
All the (rendered) text should be under 1000 characters (including spaces and punctuation) and under 6 paragraphs (without any subsections, etc).
atm, charactercounttool.com says that this PR adds "Characters (including spaces): 1721". Could you please remove some of the details and shrink the section a little?
|
sorry I didn't check for this rule. I have made it down to 967 chars. BTW zola is failing on trailing space which is not in my section, I don't know how to fix this? |
ozkriff
approved these changes
Feb 3, 2021
|
🚀 Merged! Thanks for the PR! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #455