Skip to content

N18: fishgame #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 3, 2021
Merged

N18: fishgame #478

merged 1 commit into from
Feb 3, 2021

Conversation

not-fl3
Copy link
Contributor

@not-fl3 not-fl3 commented Feb 3, 2021 •
edited
Loading

Part of #455

@not-fl3 not-fl3 closed this Feb 3, 2021
@not-fl3 not-fl3 deleted the fishgame branch February 3, 2021 22:15
@not-fl3 not-fl3 restored the fishgame branch February 3, 2021 22:15
@not-fl3 not-fl3 changed the title N17: fishgame N18: fishgame Feb 3, 2021
@not-fl3 not-fl3 reopened this Feb 3, 2021
17cupsofcoffee
17cupsofcoffee reviewed Feb 3, 2021
View reviewed changes
Copy link
Collaborator

@17cupsofcoffee 17cupsofcoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one minor issue with a link.

Also, could you replace the GIF with this optimized version? Should cut the size down by about a megabyte :)

fishgame

@not-fl3
Copy link
Contributor Author

not-fl3 commented Feb 3, 2021

Also, could you replace the GIF with this optimized version? Should cut the size down by about a megabyte :)

Sure, updated!
But this is awesome, I tried really hard to make it fit 2.5Mb, and actually there were more optimizations available!
How you made it? :)

@17cupsofcoffee
Copy link
Collaborator

How you made it? :)

@ozkriff linked me to https://ezgif.com/optimize and it seems to work really well :)

@17cupsofcoffee 17cupsofcoffee merged commit 2dfbdb4 into rust-gamedev:source Feb 3, 2021
@17cupsofcoffee
Copy link
Collaborator

Thank you for the PR :)

@ozkriff ozkriff mentioned this pull request Feb 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@17cupsofcoffee 17cupsofcoffee 17cupsofcoffee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@not-fl3 @17cupsofcoffee