Skip to content

N19: Add wgpu/gfx/naga news #497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 6, 2021
Merged

N19: Add wgpu/gfx/naga news #497

merged 7 commits into from
Mar 6, 2021

Conversation

kvark
Copy link
Collaborator

@kvark kvark commented Mar 2, 2021

Part of #496

Copy link
Member

@ozkriff ozkriff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the (rendered) text should be under 1000 characters (including spaces and punctuation) and under 6 paragraphs (without any subsections, etc).

it's 1658 atm. The content needs to be either shortened or split into more sections.

No bold/italic/etc formatting - only links and one plain list without nesting per section.

There's a nested list atm

@kvark
Copy link
Collaborator Author

kvark commented Mar 2, 2021

Thank you for the review! How about now?

@ozkriff
Copy link
Member

ozkriff commented Mar 3, 2021

wgpu and gfx sections look great but naga's nested list still doesn't fit the new simplified guidelines

@ozkriff ozkriff changed the title Add wgpu/gfx/naga news to N19 N19: Add wgpu/gfx/naga news Mar 3, 2021
@kvark
Copy link
Collaborator Author

kvark commented Mar 3, 2021

Removed the nesting now. I find this limitation unfortunate :/

Copy link
Collaborator

@17cupsofcoffee 17cupsofcoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now 👍

Personally I think one level of nesting wouldn't be the worst thing in the world, if a list needed breaking up into categories or something like that.

I think the intent of the guidelines is to nudge people away from just dumping a massive changelog in each newsletter (writeups are a bit nicer to read), but for big projects with lots of seperate work streams like WGPU, I feel like it'd be hard to avoid the bullet point approach. Might be one to discuss going forward.

@17cupsofcoffee 17cupsofcoffee requested a review from ozkriff March 5, 2021 18:18
@kvark
Copy link
Collaborator Author

kvark commented Mar 6, 2021

I admit this PR does look rather boring with these lists and no screenshots. But that's what we have right now, so better than nothing anyway.

@ozkriff ozkriff merged commit 02bfc64 into source Mar 6, 2021
@ozkriff
Copy link
Member

ozkriff commented Mar 6, 2021

Merged, thanks for the PR!

And, yeah, maybe we should relax some of these formatting limitations. 🤔

@kvark kvark deleted the kvark-patch-1 branch March 6, 2021 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants