-
Notifications
You must be signed in to change notification settings - Fork 344
N19: Add wgpu/gfx/naga news #497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the (rendered) text should be under 1000 characters (including spaces and punctuation) and under 6 paragraphs (without any subsections, etc).
it's 1658 atm. The content needs to be either shortened or split into more sections.
No bold/italic/etc formatting - only links and one plain list without nesting per section.
There's a nested list atm
Thank you for the review! How about now? |
wgpu and gfx sections look great but naga's nested list still doesn't fit the new simplified guidelines |
Removed the nesting now. I find this limitation unfortunate :/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now 👍
Personally I think one level of nesting wouldn't be the worst thing in the world, if a list needed breaking up into categories or something like that.
I think the intent of the guidelines is to nudge people away from just dumping a massive changelog in each newsletter (writeups are a bit nicer to read), but for big projects with lots of seperate work streams like WGPU, I feel like it'd be hard to avoid the bullet point approach. Might be one to discuss going forward.
I admit this PR does look rather boring with these lists and no screenshots. But that's what we have right now, so better than nothing anyway. |
Merged, thanks for the PR! And, yeah, maybe we should relax some of these formatting limitations. 🤔 |
Part of #496