Skip to content

N23: Add opencombat game #678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 1, 2021
Merged

N23: Add opencombat game #678

merged 3 commits into from
Jul 1, 2021

Conversation

buxx
Copy link
Contributor

@buxx buxx commented Jul 1, 2021

Add Open Combat game update.

Part of #677

@buxx
Copy link
Contributor Author

buxx commented Jul 1, 2021

Hello, it is my first PR ! I don't know how check mardown lint for now :(

17cupsofcoffee
17cupsofcoffee reviewed Jul 1, 2021
View reviewed changes
Copy link
Collaborator

@17cupsofcoffee 17cupsofcoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some minor formatting/grammar tweaks, but looks pretty much in line with what we want :)

@ozkriff ozkriff changed the title Add opencombat game update to newsletter 23 N23: Add opencombat game Jul 1, 2021
@buxx
Copy link
Contributor Author

buxx commented Jul 1, 2021

Nice ! Thanks you.

ozkriff
ozkriff approved these changes Jul 1, 2021
View reviewed changes
Copy link
Member

@ozkriff ozkriff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 (made a few small style tweaks: the discussions are supposed to be links to already happened threads with comments)

@ozkriff ozkriff merged commit 5fc73fd into rust-gamedev:source Jul 1, 2021
@ozkriff
Copy link
Member

ozkriff commented Jul 1, 2021

Merged, thanks for the PR!

@ozkriff ozkriff mentioned this pull request Jul 1, 2021
Closed
53 tasks
@buxx buxx deleted the n23-open-combat branch July 2, 2021 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ozkriff ozkriff ozkriff approved these changes

@17cupsofcoffee 17cupsofcoffee 17cupsofcoffee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@buxx @ozkriff @17cupsofcoffee