-
Notifications
You must be signed in to change notification settings - Fork 344
N30: Release, take 2 #944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
N30: Release, take 2 #944
Conversation
⏰ Planning to get this merged at around 9PM GMT (three and a half hours from now), assuming no issues found. |
Going to have to push this back till tomorrow as I'm dealing with my second work callout of the evening... fun times 😅 |
I just noticed a broken link in the rafx post. This:
should be:
I can PR this in a few hours (or feel free to slip it in if that's the easiest way to fix it.) |
@aclysma: I'll just fix it here, thanks for the heads up! |
Nice catch! Might be good to set up some regex like |
There are legitimate cases for the first syntax so I’d expect detecting this sort of mistake would require something more sophisticated (like actual dead-link checking). I do think running the rendered page through a link checker during final review wouldn’t be a bad idea but I’m hesitant to suggest anything that adds more burden on editors who are already volunteering a lot of time. |
I actually think Zola might have some kind of link checker built in, I'll do a bit of digging into that after this newsletter's done. |
Should be
|
I'm not sure the beginning of this sentence makes sense? |
Pedantic, but
should be
|
(my fault)
should be
|
should be
|
Co-authored-by: Joe Clay <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍
I've updated the Netlify preview - going to try and get this merged finally in a couple of hours. |
Part of #912
Netlify preview: https://sharp-aryabhata-9cc78b.netlify.app/news/030/
A contributor asked for a little more time to finish their section, so I reverted last night's release PR. Here it is again - changes from last night are: