Skip to content

N30: Release, take 2 #944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Feb 10, 2022
Merged

N30: Release, take 2 #944

merged 10 commits into from
Feb 10, 2022

Conversation

17cupsofcoffee
Copy link
Collaborator

Part of #912

Netlify preview: https://sharp-aryabhata-9cc78b.netlify.app/news/030/

A contributor asked for a little more time to finish their section, so I reverted last night's release PR. Here it is again - changes from last night are:

  • Graphite section has been added to 'Tooling Updates' (the image was broken so I've fixed as part of this PR).
  • A few extra bullet points have been added to Bevy Cheatbook's section.
  • I snuck in a tweak to the formatting on horizontal rules, as it's been bothering me for months how cramped they look 😄

@17cupsofcoffee
Copy link
Collaborator Author

⏰ Planning to get this merged at around 9PM GMT (three and a half hours from now), assuming no issues found.

@17cupsofcoffee
Copy link
Collaborator Author

Going to have to push this back till tomorrow as I'm dealing with my second work callout of the evening... fun times 😅

@aclysma
Copy link
Contributor

aclysma commented Feb 10, 2022

I just noticed a broken link in the rafx post.

This:

[video demonstrating TAA](rafx-youtube-video)

should be:

[video demonstrating TAA][rafx-youtube-video]

I can PR this in a few hours (or feel free to slip it in if that's the easiest way to fix it.)

@17cupsofcoffee
Copy link
Collaborator Author

@aclysma: I'll just fix it here, thanks for the heads up!

@Keavon
Copy link
Contributor

Keavon commented Feb 10, 2022

I just noticed a broken link in the rafx post.

Nice catch! Might be good to set up some regex like \[[^\[\]]+?\]\([^()]+?\) to detect that as part of the build process, or at least as a step in the release process to check for that.

@aclysma
Copy link
Contributor

aclysma commented Feb 10, 2022

There are legitimate cases for the first syntax so I’d expect detecting this sort of mistake would require something more sophisticated (like actual dead-link checking).

I do think running the rendered page through a link checker during final review wouldn’t be a bad idea but I’m hesitant to suggest anything that adds more burden on editors who are already volunteering a lot of time.

@17cupsofcoffee
Copy link
Collaborator Author

I actually think Zola might have some kind of link checker built in, I'll do a bit of digging into that after this newsletter's done.

@AngelOnFira
Copy link
Member

Something incredible has been brewing within the small by dedicated community of the original game.

Should be

Something incredible has been brewing within the small but dedicated community of the original game.

@AngelOnFira
Copy link
Member

Basic concept worked on the terrain, and the mini working group transitioned

I'm not sure the beginning of this sentence makes sense?

@AngelOnFira
Copy link
Member

Pedantic, but

discussing Windows specific performance tweaks in Way of Rhea's engine

should be

discussing Windows-specific performance tweaks in Way of Rhea's engine

@AngelOnFira
Copy link
Member

(my fault)

Several shaders experimental shaders have been added, along with a "point glow" which help lanterns look better.

should be

Several shaders experimental shaders have been added, along with a "point glow" which helps lanterns look better.

@AngelOnFira
Copy link
Member

Last couple of months saw great disappointment for the failed port to WGPU

should be

The last couple of months saw great disappointment for the failed port to WGPU

Copy link
Member

@AngelOnFira AngelOnFira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@17cupsofcoffee
Copy link
Collaborator Author

I've updated the Netlify preview - going to try and get this merged finally in a couple of hours.

@17cupsofcoffee 17cupsofcoffee merged commit 8565455 into source Feb 10, 2022
@17cupsofcoffee 17cupsofcoffee deleted the n30-release-2 branch February 10, 2022 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants