-
Notifications
You must be signed in to change notification settings - Fork 302
Hide non essential parts of "Network" snippets by default #107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks! This is great. Looks like the hidden parts are awkwardly indented by one space when visible. Is that something we can fix or a mdBook bug? Is |
both indentation and
around playpen if it does not find string |
Let's fix both of those in mdBook before merging this. I think the solutions are:
|
I filed https://github.com/azerupi/mdBook/issues/281 and https://github.com/azerupi/mdBook/issues/282 to follow up on the mdBook fixes. |
@dtolnay I made (hopefully nonidiotic) PR's for both of these issues. |
Rebased and cleaned up the commit. As both problems are now fixed in upstream mdbook I would wait for the next mdbook release (0.0.22) @azerupi |
Updated net.md to hide error_chain boilerplate by default it can be exposed by selecting the "expand button" The expand button is no longer hidden
@dtolnay mdbook has released a version (0.0.22) with fixes for both blockers. If the idea and this PR is ok then I'll gladly update rest of the examples. |
Thanks! |
Updated net.md to hide error_chain boilerplate by default
it can be exposed by selecting the "expand button"
The expand button is no longer hidden
This is connected to https://github.com/brson/rust-cookbook/issues/106
@dtolnay please check if net.md and decide if such approach is acceptable