Parsing subprocess output #122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Both cathegories look appropriate |
|
Cheers @budziq! If everything looks okay, this should be ready to merge. |
|
@Michael-F-Bryan excellent work! Only one minor nit. All git commits are shown which makes the |
|
Good spot, I've limited it to just the last 5 commits so that should fix it. Is there anything else which can be improved? |
|
Looks very good to me. But all maintainers are based in US so merge will have to wait a little. |
|
Nicely done. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an example which calls
git log --onelinein a subprocess and parses stdout to grab the hash and commit message for all commits in the current repo's history as discussed in #108.I'm not quite sure which category this example belongs in. About the closes thing would be
filesystem, but calling a subprocess doesn't really have anything to do with the filesystem...(fixes #108)