Update SEO titles on index page and post pages #344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the SEO title (i.e.,
<title>,twitter:title, andog:title) for the index page and post pages.Current SEO Titles
Index page
"Blog"
Post Page
"The Rust Programming Language Blog"
SEO Titles After Change
Index page
"The Rust Programming Language Blog"
Post Page
"
post.title| Rust Blog"Note on other approaches: I went through an earlier approach that added a second attribute on the render data (e.g.,
"seo_title"), but I ultimately did not go with it because index.hbs is used to render only one page, so hardcoding "Blog" seems reasonable.If merged, this fixes #315 (and also the index page). I modified the suggested string in #315 because I found more examples of blog posts that combine the post title and blog name than just use the post title. I'm happy to change it to anything else, if there's a strong preference otherwise.