Skip to content

Support release version numbers for start/end range #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ehuss opened this issue Mar 27, 2022 · 3 comments
Closed

Support release version numbers for start/end range #146

ehuss opened this issue Mar 27, 2022 · 3 comments

Comments

@ehuss
Copy link
Collaborator

ehuss commented Mar 27, 2022

Problem

Often I know a regression happened between two specific stable versions of Rust. However, it is not terribly easy to use cargo-bisect-rustc with a range of those two releases.

Proposed Solution

Support release tags in --start and --end (in addition to dates and hashes).

I think the commit can be found with git merge-base master $TAG, though I'm not certain that will always work.

@Kobzol
Copy link
Contributor

Kobzol commented Mar 30, 2022

I tried to add support for resolving tags and it can be done quite easily by using revparse_ext instead of revparse_single for parsing revisions for the local resolves (the GitHub backend can resolve tags directly). Then I realized that resolving tags is not the problem at all :D The problem is that release commits are not in master. I sent a PR: #147

@Kobzol
Copy link
Contributor

Kobzol commented Apr 2, 2022

Should be resolved by #147.

@ehuss
Copy link
Collaborator Author

ehuss commented Apr 2, 2022

Yep, thanks!

@ehuss ehuss closed this as completed Apr 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants