-
Notifications
You must be signed in to change notification settings - Fork 57
Add support for git tags in --start
and --end
#147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Nice! Can you add some text to the CLI help for the |
Added CLI help. Maybe we should also rename |
I don't feel a particular need to rename it. However, it looks like the new code needs to be formatted. |
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@Kobzol This seems to have broken bisecting by hash. Can you take a look at fixing it? For example:
will error with:
I notice that the end commit has shifted from ec667fbcfcd29e2b5080f6be04e229356b27e600 to |
It seems that the problem is that |
First I tried to add new
Bound
(Version
), but that required a lot of changes in the code.I think that just adding support for arbitrary tags is more general and should hopefully work out of the box. I changed the GH resolver to use the
compare
API, which allows us to get commit information together withmerge-base
ancestor.