Improve message for no CI builds found and various cleanup #121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
camelid
commented
Nov 1, 2020
camelid
commented
- Improve message for no CI builds found
- Various cleanup
camelid
commented
Nov 1, 2020
| @@ -1146,7 +1142,7 @@ fn bisect_ci_in_commits( | |||
|
|
|||
| if commits.is_empty() { | |||
| bail!( | |||
| "no commits between {} and {} within last 167 days", | |||
| "no CI builds available between {} and {} within last 167 days", | |||
There was a problem hiding this comment.
This error message confuses me: What does it mean by "within last 167 days"?
There was a problem hiding this comment.
after 167 days artifacts are removed from the CI, so you can't install nightlies older than 167 days ago.
|
r? @spastorino |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.