Reduce technical debt #153
Conversation
Important before moving from `StructOpt` to `clap`
`failure` is deprecated in favour of these two librairies Update `Cargo.lock` and `Cargo.toml`
by anyhow::Result<_> or true error type when possible
`Structopt` is now in maintenance-only mode and advise to use `clap` instead
Made possible with using `thiserror`
This will also allow to display the correct default value with `--help` `--host` and `--target` have the same goal and probably `--host` should be removed but for a later work
|
CLI snapshots tests are failing on windows, I'll investigate but I think it's an issue with the test rather than with the behaviour |
|
General note: I think I would prefer |
Not to pass `Config` and `Client` every time
|
CI fixed, and previous comments should have been addressed.
I am not familiar with the library, from what I see the difference is that it includes |
|
Thanks! I went ahead and merged it, since it can stand on its own. Yea, using spantrace and being more developer focussed is good here, as failures in the tool are likely going to be debugged by users of the tool as you noted. Let's do that in a separate PR tho |
No functional change
Replace deprecated/no-longer-maintained crates with a up-to-date replacement:
structopt->clapallowing for more validation to be done during arguments passingfailure->thiserror+anyhowalong with more tests and some refactoring.
this PR has maybe grown too big, and I can split it if needed, although efforts were made for it to be reviewed on a per-commit basis.