Skip to content

feat(add/install): check if given crate argument would be valid with inserted @ symbol #15441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 28, 2025
Merged

feat(add/install): check if given crate argument would be valid with inserted @ symbol #15441

merged 4 commits into from
Apr 28, 2025

Conversation

dawedawe
Copy link
Contributor

Suggest to user to use a crate name with an inserted @ before the first invalid package name character

Fixes #15318

@rustbot
Copy link
Collaborator

rustbot commented Apr 20, 2025

r? @ehuss

rustbot has assigned @ehuss.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-cli Area: Command-line interface, option parsing, etc. Command-add Command-install S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 20, 2025
weihanglo
weihanglo approved these changes Apr 21, 2025
View reviewed changes
Copy link
Member

@weihanglo weihanglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch!

@weihanglo weihanglo self-requested a review April 21, 2025 00:25
weihanglo
weihanglo reviewed Apr 21, 2025
View reviewed changes
Copy link
Member

@weihanglo weihanglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a blocker. Would you mind following the atomic commit pattern described here. That is,

As part of your atomic commits, prefer adding tests as their own commit before any functionality changes. The tests should pass in each commit, demonstrating the behavior before your change and how each commit affects behavior.

@ehuss ehuss assigned weihanglo and unassigned ehuss Apr 21, 2025
@dawedawe
Copy link
Contributor Author

Not a blocker. Would you mind following the atomic commit pattern described here. That is,

As part of your atomic commits, prefer adding tests as their own commit before any functionality changes. The tests should pass in each commit, demonstrating the behavior before your change and how each commit affects behavior.

Oops, sorry. Should have seen that.
Thanks for the review!

@epage
Copy link
Contributor

epage commented Apr 21, 2025

As a suggestion to clarify what is being asked by the link to the contributor guide, including the tip. The commits could be organized as:

  1. A commit that adds all of the tests, with them passing (or separate commits for cargo add and cargo install)
  2. A commit that changes cargo install, and updates the tests to pass
  3. A commit that changes cargo add, and updates the tests to pass

We're fine with your rewriting your commits during the review process.

@dawedawe dawedawe force-pushed the suggest_crate_name_fix branch 3 times, most recently from c46ba9c to 8c9b373 Compare April 21, 2025 16:31
@dawedawe
Copy link
Contributor Author

Okay, I hope the history is acceptable now.

epage
epage reviewed Apr 21, 2025
View reviewed changes
@epage
Copy link
Contributor

epage commented Apr 21, 2025

Okay, I hope the history is acceptable now.

Thanks, this helps a lot!

@dawedawe dawedawe force-pushed the suggest_crate_name_fix branch 2 times, most recently from 55042a0 to a8010c2 Compare April 26, 2025 21:29
@dawedawe dawedawe force-pushed the suggest_crate_name_fix branch from a8010c2 to 0df8d68 Compare April 26, 2025 23:25
@epage
Copy link
Contributor

epage commented Apr 28, 2025

Thanks!

@epage epage added this pull request to the merge queue Apr 28, 2025
Merged via the queue into rust-lang:master with commit 538c163 Apr 28, 2025
25 checks passed
@dawedawe dawedawe deleted the suggest_crate_name_fix branch April 28, 2025 16:17
@weihanglo weihanglo mentioned this pull request May 9, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 10, 2025
@bors
Auto merge of rust-lang#140876 - weihanglo:update-cargo, r=weihanglo
c6faa1b 
Update cargo

25 commits in 7918c7eb59614c39f1c4e27e99d557720976bdd7..056f5f4f3c100cb36b5e9aed2d20b9ea70aae295
2025-04-27 09:44:23 +0000 to 2025-05-09 14:54:18 +0000
- Revert "doc: Mention `XDG_DATA_HOME`" (rust-lang/cargo#15512)
- docs: update version notice for deprecation removal (rust-lang/cargo#15511)
- doc: Update instructions on using native-completions (rust-lang/cargo#15480)
- feat(network): use Retry-After header for HTTP 429 responses (rust-lang/cargo#15463)
- CI: Require schema job to pass (rust-lang/cargo#15504)
- chore(config): migrate renovate config (rust-lang/cargo#15501)
- Make cargo script ignore workspaces (rust-lang/cargo#15496)
- fix(rustc): Don't panic on unknown bins (rust-lang/cargo#15497)
- test: Remove unused nightly requirements (rust-lang/cargo#15498)
- Add support for `-Zembed-metadata` (rust-lang/cargo#15378)
- Fix tracking issue template link (rust-lang/cargo#15494)
- Refactor artifact deps in FeatureResolver::deps (rust-lang/cargo#15492)
- Improved error message for versions prefixed with `v` (rust-lang/cargo#15484)
- chore: fix some typos in comment (rust-lang/cargo#15485)
- fix: default to all targets when using `--edition` and ` --edition-idioms` in cargo fix (rust-lang/cargo#15192)
- Update fingerprint footnote (rust-lang/cargo#15478)
- feat(add): suggest similarly named features (rust-lang/cargo#15438)
- In package-workspace, keep dev-dependencies if they have a version (rust-lang/cargo#15470)
- docs: fix a typo in DependencyUI (rust-lang/cargo#15472)
- fix grammar, and remove confusing example (rust-lang/cargo#15457)
- Added tracing spans for rustc invocations (rust-lang/cargo#15464)
- Trivial tweaks to 'target_short_hash' (rust-lang/cargo#15461)
- chore(deps): update msrv (3 versions) to v1.84 (rust-lang/cargo#15456)
- feat(add/install): check if given crate argument would be valid with inserted @ symbol (rust-lang/cargo#15441)
- chang 1 tries to 1 try (rust-lang/cargo#15328)

r? ghost
@rustbot rustbot added this to the 1.89.0 milestone May 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weihanglo weihanglo weihanglo approved these changes

@epage epage epage approved these changes

Assignees

@weihanglo weihanglo

Labels
A-cli Area: Command-line interface, option parsing, etc. Command-add Command-install S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
1.89.0
Development

Successfully merging this pull request may close these issues.

cargo install foo=1.2.3 does not detect invalid character
5 participants
@dawedawe @rustbot @epage @weihanglo @ehuss