Replace the bl! macro with asm_sym
#820
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross35
force-pushed
the
remove-bl-macro
branch
2 times, most recently
from
dcea253 to
2de8adf
Compare
tgross35
force-pushed
the
remove-bl-macro
branch
2 times, most recently
from
42931e5 to
10cc3c3
Compare
tgross35
force-pushed
the
remove-bl-macro
branch
2 times, most recently
from
e2636a9 to
6f2e91f
Compare
`bl!` is being used to add a leading underscore on Apple targets. `asm_sym` has been around since 2022 and handles platform-specific symbol names automatically, so make use of this instead. I have verified that `armv7s-apple-ios` still builds correctly.
tgross35
force-pushed
the
remove-bl-macro
branch
from
6f2e91f to
655ac67
Compare
tgross35
added a commit
to tgross35/rust
that referenced
this pull request
Apr 17, 2025
Includes the following changes: * Replace `#[naked]` with `#[unsafe(naked)]` [1] [2] * Replace `bl!` with `asm_sym` [3] [1]: rust-lang/compiler-builtins#817 [2]: rust-lang/compiler-builtins#821 [3]: rust-lang/compiler-builtins#820
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 17, 2025
Update `compiler-builtins` to 0.1.155 Includes the following changes: * Replace `#[naked]` with `#[unsafe(naked)]` [1] [2] * Replace `bl!` with `asm_sym` [3] [1]: rust-lang/compiler-builtins#817 [2]: rust-lang/compiler-builtins#821 [3]: rust-lang/compiler-builtins#820 try-job: armhf-gnu try-job: aarch64-apple try-job: dist-apple-various
folkertdev
pushed a commit
to folkertdev/rust
that referenced
this pull request
Apr 17, 2025
Includes the following changes: * Replace `#[naked]` with `#[unsafe(naked)]` [1] [2] * Replace `bl!` with `asm_sym` [3] [1]: rust-lang/compiler-builtins#817 [2]: rust-lang/compiler-builtins#821 [3]: rust-lang/compiler-builtins#820
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Apr 18, 2025
Update `compiler-builtins` to 0.1.155 Includes the following changes: * Replace `#[naked]` with `#[unsafe(naked)]` [1] [2] * Replace `bl!` with `asm_sym` [3] [1]: rust-lang/compiler-builtins#817 [2]: rust-lang/compiler-builtins#821 [3]: rust-lang/compiler-builtins#820 try-job: armhf-gnu try-job: aarch64-apple try-job: dist-apple-various
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 18, 2025
Rollup merge of rust-lang#139934 - tgross35:update-builtins, r=tgross35 Update `compiler-builtins` to 0.1.155 Includes the following changes: * Replace `#[naked]` with `#[unsafe(naked)]` [1] [2] * Replace `bl!` with `asm_sym` [3] [1]: rust-lang/compiler-builtins#817 [2]: rust-lang/compiler-builtins#821 [3]: rust-lang/compiler-builtins#820 try-job: armhf-gnu try-job: aarch64-apple try-job: dist-apple-various
github-actions bot
pushed a commit
to model-checking/verify-rust-std
that referenced
this pull request
Apr 19, 2025
Includes the following changes: * Replace `#[naked]` with `#[unsafe(naked)]` [1] [2] * Replace `bl!` with `asm_sym` [3] [1]: rust-lang/compiler-builtins#817 [2]: rust-lang/compiler-builtins#821 [3]: rust-lang/compiler-builtins#820
github-actions bot
pushed a commit
to model-checking/verify-rust-std
that referenced
this pull request
Apr 19, 2025
Update `compiler-builtins` to 0.1.155 Includes the following changes: * Replace `#[naked]` with `#[unsafe(naked)]` [1] [2] * Replace `bl!` with `asm_sym` [3] [1]: rust-lang/compiler-builtins#817 [2]: rust-lang/compiler-builtins#821 [3]: rust-lang/compiler-builtins#820 try-job: armhf-gnu try-job: aarch64-apple try-job: dist-apple-various
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bl!is being used to add a leading underscore on Apple targets.asm_symhas been around since 2022 and handles platform-specificsymbol names automatically, so make use of this instead.
I have verified that
armv7s-apple-iosstill builds correctly.